From 5dbd0b37f2d2d96db05e36e1f29ff57a6558caf5 Mon Sep 17 00:00:00 2001 From: Thorvald Larsen Date: Tue, 24 Oct 2017 17:10:55 +0200 Subject: [PATCH 1/5] SGS100A Driver Adding parameter to SGS100A driver to allow on/off of IQ modulation. --- .DS_Store | Bin 0 -> 6148 bytes qcodes/.DS_Store | Bin 0 -> 8196 bytes qcodes/instrument_drivers/.DS_Store | Bin 0 -> 6148 bytes .../instrument_drivers/rohde_schwarz/SGS100A.py | 11 +++++++++++ 4 files changed, 11 insertions(+) create mode 100644 .DS_Store create mode 100644 qcodes/.DS_Store create mode 100644 qcodes/instrument_drivers/.DS_Store diff --git a/.DS_Store b/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..b2bfa2076ebd236aa4052838b04c1879127658da GIT binary patch literal 6148 zcmeHK!A=4(5N!c*H^#`pM2@|9;{ZYAWU@g#cr(H1K@IG>L^i=KvWpvCG5Z_(M}C37 z<4jwK1U+~$MrM-fn@(ri^zEk8GRAmo;@21}F~%%V#GDPy7lPxcOOi7lM6TxOv&c)L zkvEjyQZzaKA_MsCitLVEGs%3m`2F6z(J+YOYW1Dx@`bhHx@Fszy=h%_1~TcyZaj%v z?)XCW0>AGW`&7!|+;+XQpr3S0+lMlY-5~6bKZReO2ca*MmYjrsq~GO+bmcvh|WXs?TUcp${5CcDB0M7>jis%^3G^(Qm8oWN@cmWXw zY7la6h7Z;ff*U-v{otF2@ebMlLD;;3Q^4KAOD1E3vKy(y!U3H6Q(oe&AeBj zR*M*n2`m5N&w^+)M%k#rCHS*KT^XAYFuG7SZcrDxz(hTF?!1N;s_Y~%H<>we?>Xn* zd%k|>-ket=LTkZnB&s1Ig&!gHnf$s*6MFI7&=S!|IZLoVQJxAkKo+?a++ZCK#0bO) z#0bO)#0bO)+ztrvoh_O&#l0`J@jFH!M&PbQK%5UreuPX#a#YIj=-^ja0wwTF8Oc;6N2Ls1c}`h9AaX@iVnDjHJ}JyurXo2irF17qcS5u>q6!7!>g<;c%?T+f z<9CcejKGZui1euTHC1O>k}liwZoY}3j{-`$?)jDKgcJ8f$ytyi~sZjiBED}SB& zo*vsZy`fgG;F^9oPiH3RXWww4v|ckj+_Y*{eX^;sail&u+}zwypIq6rdSpaV<}7Sn zw`u>t(PP6;jXeFjj2F?FK^2qYf8$nzcl=_T3_dYd3jXqV@b}ErW*M8eY~7}9@3nKD z+hrfK(t3r@Xl&wcXWlAutUWo;DGa!NTCdDyoLs@l1XhdV2xA_r@N;?3aXLNU4s6fu z>kX_UL2051s@`3`mk-*)$GkSC0zyOEnM`JCmhOtj9yEWqn+XpR|w{$_Q&7rO5E%gaqi)o4tDRrs6 zpM~hvr4~yR>!ctGQBieqc^ULDt>Me6n+}ji$LSQErn7X8&eK=)E&V`O=qmj|f6`y{ zHwY>!FcZ#T)JZA+Q(bRNivBU*Yh(ZrDR>m#uD2? zB21w8n9LGwUMYhnr^^l|vvoufIi=5#)(_P#P?(3hBD;%fmnfVmdLry<^|i}Y&Ii3r zY8$mCg_*BUliJnV8kKWHFPGX!wRH-ofIeMn4Xs60b&{P$wH>OWqI)^r(30Su`BO7o_mn(OQ|t& zsyn+^Cc~={^?%3IzyIIaAjHwd2;AiepuD}Sy_G?j>JUt@F3Hb+enb;?qf&-0{1PT& lJS@jqj{n1uzmt(J70FR4S;OuB`5{1!@BjGz_wVNW{~yojV5tBA literal 0 HcmV?d00001 diff --git a/qcodes/instrument_drivers/.DS_Store b/qcodes/instrument_drivers/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..2332f3527ab2820f2f685bcb5be6a8ba554663d3 GIT binary patch literal 6148 zcmeHK!Ab)$5S_GDw}{w-V2`!GD;Pr_2`!JAOggG#&W7Q0Y4(%rh)TG`*wKk^Iw z9cPlXC{<4)Qf6TCCX<~hUZ_(lPbT%fy^5^YYSW6GG#b^4+^z3Vr;f9|Q#&~B-ad>ckJG1T!?VCoQp={r z8N8tJ!UlQFaylM?=e94gG42CEoKJw z)qxHDKGJxBkOXadOAtznuEoqCj-UvWifB@WePRfcj(%z5T#K1OlMX_!jPux)g?*t2 zy*m1(4hP{H Date: Tue, 24 Oct 2017 17:14:32 +0200 Subject: [PATCH 2/5] Change parameter name Forgot to change a few lines in previous commit. --- qcodes/instrument_drivers/rohde_schwarz/SGS100A.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py b/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py index 1804745b167..7454107aadf 100644 --- a/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py +++ b/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py @@ -56,9 +56,9 @@ def __init__(self, name, address, **kwargs): set_cmd=self.set_status, get_parser=self.parse_on_off, vals=vals.Strings()) - self.add_parameter('status', + self.add_parameter('IQ_state', get_cmd=':IQ:STAT?', - set_cmd=self.set_status, + set_cmd=self.set_IQ_state, get_parser=self.parse_on_off, vals=vals.Strings()) self.add_parameter('pulsemod_state', @@ -106,7 +106,8 @@ def set_status(self, stat): else: raise ValueError('Unable to set status to %s, ' % stat + 'expected "ON" or "OFF"') - def set_status(self, stat): + + def set_IQ_state(self, stat): if stat.upper() in ('ON', 'OFF'): self.write(':IQ:STAT %s' % stat) else: From 68d5812060919faa949eaaf5a46452a3380b410f Mon Sep 17 00:00:00 2001 From: Jens Hedegaard Nielsen Date: Thu, 26 Oct 2017 15:28:36 +0200 Subject: [PATCH 3/5] Strip trailing whitespace --- qcodes/instrument_drivers/rohde_schwarz/SGS100A.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py b/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py index 7454107aadf..bb487cd730d 100644 --- a/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py +++ b/qcodes/instrument_drivers/rohde_schwarz/SGS100A.py @@ -106,7 +106,7 @@ def set_status(self, stat): else: raise ValueError('Unable to set status to %s, ' % stat + 'expected "ON" or "OFF"') - + def set_IQ_state(self, stat): if stat.upper() in ('ON', 'OFF'): self.write(':IQ:STAT %s' % stat) From f8ce2c202382c48b2ffed28ded3b680be3856fff Mon Sep 17 00:00:00 2001 From: Jens Hedegaard Nielsen Date: Thu, 26 Oct 2017 15:31:51 +0200 Subject: [PATCH 4/5] remove .DS_Store files --- .DS_Store | Bin 6148 -> 0 bytes qcodes/.DS_Store | Bin 8196 -> 0 bytes qcodes/instrument_drivers/.DS_Store | Bin 6148 -> 0 bytes 3 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .DS_Store delete mode 100644 qcodes/.DS_Store delete mode 100644 qcodes/instrument_drivers/.DS_Store diff --git a/.DS_Store b/.DS_Store deleted file mode 100644 index b2bfa2076ebd236aa4052838b04c1879127658da..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6148 zcmeHK!A=4(5N!c*H^#`pM2@|9;{ZYAWU@g#cr(H1K@IG>L^i=KvWpvCG5Z_(M}C37 z<4jwK1U+~$MrM-fn@(ri^zEk8GRAmo;@21}F~%%V#GDPy7lPxcOOi7lM6TxOv&c)L zkvEjyQZzaKA_MsCitLVEGs%3m`2F6z(J+YOYW1Dx@`bhHx@Fszy=h%_1~TcyZaj%v z?)XCW0>AGW`&7!|+;+XQpr3S0+lMlY-5~6bKZReO2ca*MmYjrsq~GO+bmcvh|WXs?TUcp${5CcDB0M7>jis%^3G^(Qm8oWN@cmWXw zY7la6h7Z;ff*U-v{otF2@ebMlLD;;3Q^4KAOD1E3vKy(y!U3H6Q(oe&AeBj zR*M*n2`m5N&w^+)M%k#rCHS*KT^XAYFuG7SZcrDxz(hTF?!1N;s_Y~%H<>we?>Xn* zd%k|>-ket=LTkZnB&s1Ig&!gHnf$s*6MFI7&=S!|IZLoVQJxAkKo+?a++ZCK#0bO) z#0bO)#0bO)+ztrvoh_O&#l0`J@jFH!M&PbQK%5UreuPX#a#YIj=-^ja0wwTF8Oc;6N2Ls1c}`h9AaX@iVnDjHJ}JyurXo2irF17qcS5u>q6!7!>g<;c%?T+f z<9CcejKGZui1euTHC1O>k}liwZoY}3j{-`$?)jDKgcJ8f$ytyi~sZjiBED}SB& zo*vsZy`fgG;F^9oPiH3RXWww4v|ckj+_Y*{eX^;sail&u+}zwypIq6rdSpaV<}7Sn zw`u>t(PP6;jXeFjj2F?FK^2qYf8$nzcl=_T3_dYd3jXqV@b}ErW*M8eY~7}9@3nKD z+hrfK(t3r@Xl&wcXWlAutUWo;DGa!NTCdDyoLs@l1XhdV2xA_r@N;?3aXLNU4s6fu z>kX_UL2051s@`3`mk-*)$GkSC0zyOEnM`JCmhOtj9yEWqn+XpR|w{$_Q&7rO5E%gaqi)o4tDRrs6 zpM~hvr4~yR>!ctGQBieqc^ULDt>Me6n+}ji$LSQErn7X8&eK=)E&V`O=qmj|f6`y{ zHwY>!FcZ#T)JZA+Q(bRNivBU*Yh(ZrDR>m#uD2? zB21w8n9LGwUMYhnr^^l|vvoufIi=5#)(_P#P?(3hBD;%fmnfVmdLry<^|i}Y&Ii3r zY8$mCg_*BUliJnV8kKWHFPGX!wRH-ofIeMn4Xs60b&{P$wH>OWqI)^r(30Su`BO7o_mn(OQ|t& zsyn+^Cc~={^?%3IzyIIaAjHwd2;AiepuD}Sy_G?j>JUt@F3Hb+enb;?qf&-0{1PT& lJS@jqj{n1uzmt(J70FR4S;OuB`5{1!@BjGz_wVNW{~yojV5tBA diff --git a/qcodes/instrument_drivers/.DS_Store b/qcodes/instrument_drivers/.DS_Store deleted file mode 100644 index 2332f3527ab2820f2f685bcb5be6a8ba554663d3..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6148 zcmeHK!Ab)$5S_GDw}{w-V2`!GD;Pr_2`!JAOggG#&W7Q0Y4(%rh)TG`*wKk^Iw z9cPlXC{<4)Qf6TCCX<~hUZ_(lPbT%fy^5^YYSW6GG#b^4+^z3Vr;f9|Q#&~B-ad>ckJG1T!?VCoQp={r z8N8tJ!UlQFaylM?=e94gG42CEoKJw z)qxHDKGJxBkOXadOAtznuEoqCj-UvWifB@WePRfcj(%z5T#K1OlMX_!jPux)g?*t2 zy*m1(4hP{H Date: Thu, 26 Oct 2017 15:32:35 +0200 Subject: [PATCH 5/5] Ignore DS_Store --- .gitignore | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index dde5f156f2a..f727e6ed339 100644 --- a/.gitignore +++ b/.gitignore @@ -79,4 +79,7 @@ tmp/ docs/examples/data/* -.idea/ \ No newline at end of file +.idea/ + +# Mac files +.DS_Store