-
Notifications
You must be signed in to change notification settings - Fork 129
Consider moving build to CMake #76
Comments
please no. It badly breaks builds for Windows on ARM |
As pointed out in the opening comment, CMake is a requirement for the .NET JIT so it can't be avoided. Hence sticking with manual VS build files and an eventual Makefile doesn't get us away from needing to use CMake. |
Once our changes land upstream in CPython then CMake may be useful for having a single build target in the top directory that used CoreCLR's CMake rules so that it was CMake all the way down (and we currently need to build CoreCLR as we statically link it into Pyjion). |
CoreCLR is built with Razzle for builds that ship with Windows and the official CoreCLR .NET Core RC2 builds, not a single bit of CMake. |
@kika123 : that might be true for WIndows, but that doesn't cover Linux or OS X. And obviously those build files are generated using CMake: https://github.com/dotnet/coreclr/blob/master/CMakeLists.txt . I realize you don't want CMake used for your Windows on ARM use-case, but unless you're willing to develop and maintain a build setup that works on Windows, OS X, and Linux for Pyjion, going with the build solution that our biggest (and as of Python 3.6, hopefully only) dependency just makes sense for simplifying our lives in keeping this project going in our spare work time. |
@brettcannon actually, my issue to get Windows on ARM with CMake .NET Core compiles got rejected and closed without justification |
It might be worth considering meson. It's a newer cross platform build system that uses and builds on some of the ideas in CMake. |
I believe @stuaxo is talking about https://github.com/mesonbuild/meson. |
Here's some info. ... [EDIT] More detail But I have no horse in this race and cmake is probably used more widely :) @ |
I have some experience with CMake and would be happy to start working on this, if it has been settled. I am very much in favor of choosing CMake, as it is very common and more people know it than other cross platform meta-build systems. |
@ethanhs if you feel up for doing this, then please do! |
Implemented in #237 :-) |
Already need it for RyuJIT anyway, plus it would make us cross-platform for building (whether our C++ code is cross-platform is another question :) .
The text was updated successfully, but these errors were encountered: