Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in the Calculator plugin #7437

Closed
alekhyareddy28 opened this issue Oct 20, 2020 · 4 comments
Closed

Improvements in the Calculator plugin #7437

alekhyareddy28 opened this issue Oct 20, 2020 · 4 comments
Assignees
@alekhyareddy28
Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
InVEST-2010

Comments

@alekhyareddy28
Copy link
Contributor

alekhyareddy28 commented Oct 20, 2020 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

A few issues with the calculator plugin:

  1. Following the refactoring of the calculator plugin, when the result is 0 it no longer shows up.
    Eg: 1-1, sin(0) do not work because the result is 0.
  2. Exceptions are thrown when the user is entering the input but it's not complete.
    Eg: 1+2+3, an exception is thrown when the user has entered 1+2+ because according to the calculator helper this is a valid input.
  3. Exceptions are also thrown when any functions are used.
    eg: sin(0), an exception is thrown when sin is typed.

These exceptions can slow the performance of PT run.
The last set of exceptions can be thrown when a user is a searching for an app leading to a reduced speed while searching.
@alekhyareddy28 alekhyareddy28 added the Issue-Bug Something isn't working label Oct 20, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 20, 2020
@alekhyareddy28 alekhyareddy28 added Product-PowerToys Run Improved app launch PT Run (Win+R) Window and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 20, 2020
@alekhyareddy28 alekhyareddy28 added this to the InVEST-2010 milestone Oct 20, 2020
@alekhyareddy28 alekhyareddy28 added the Status-In progress This issue or work-item is under development label Oct 20, 2020
@alekhyareddy28 alekhyareddy28 self-assigned this Oct 20, 2020
@alekhyareddy28 alekhyareddy28 mentioned this issue Oct 20, 2020
Merged
5 tasks
@Jay-o-Way
Copy link
Collaborator

Somebody had the idea to use the Windows calculator core. Wouldn't that solved all (these and other) problems?

@alekhyareddy28
Copy link
Contributor Author

@Jay-o-Way I'm not sure of the feasibility but that's a nice idea. Maybe create a new issue for that with an idea enhancement tag so that it can be prioritized accordingly.

@Jay-o-Way
Copy link
Collaborator

Fist mentioning that I saw was #3697 (comment) but #2265 is already an issue.

@alekhyareddy28 alekhyareddy28 added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Oct 21, 2020
@Jay-o-Way Jay-o-Way mentioned this issue Oct 22, 2020
Closed
@crutkas
Copy link
Member

crutkas commented Oct 29, 2020

Added in 0.25. https://github.com/microsoft/PowerToys/releases/tag/v0.25.0

@crutkas crutkas closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alekhyareddy28 alekhyareddy28

Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
InVEST-2010
Development

No branches or pull requests
3 participants
@crutkas @alekhyareddy28 @Jay-o-Way