Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run] Run is draggable #7149

Closed
niels9001 opened this issue Oct 7, 2020 · 8 comments
Closed

[PT Run] Run is draggable #7149

niels9001 opened this issue Oct 7, 2020 · 8 comments
Labels
Issue-Bug Something isn't working Planning-Consideration Consideration for 2021 stability release Priority-3 Bug that is low priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@niels9001
Copy link
Contributor

Is it a feature or a bug :)? Not sure if this is flagged already. If so, please close.

ℹ Computer information

  • PowerToys version: v.0.23.0
  • PowerToy Utility: PT Run
  • Running PowerToys as Admin: Yes
  • Windows build number: 1909

📝 Provide detailed reproduction steps (if any)

  1. Press-and-hold the searchbar (where the looking glass icon is)
  2. Move your mouse around

✔️ Expected result

Nothing happens.

❌ Actual result

The window can be dragged around

📷 Screenshots

PT run bug

@niels9001 niels9001 added the Issue-Bug Something isn't working label Oct 7, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 7, 2020
@enricogior
Copy link
Contributor

@niels9001
any reason why it should not be draggable?
Beside the fact that it's currently not aware of its position so if you move it to the bottom of the screen the dropdown list is not visible, but that is a minor glitch that we can fix in the future.

@niels9001
Copy link
Contributor Author

@enricogio No not really, hence the question if it's a (unknown) feature or a bug :).

If it is a feature (which I'm all for) then we should update the UI to make it explicit that it's possible to drag it around, and expand the draggable region.

I think the latest UI elements in Windows 10(X) use the rectangle in the title bar to indicate that the window is draggable. Should be an easy add.

image

@htcfreek
Copy link
Collaborator

htcfreek commented Oct 7, 2020

@enricogio No not really, hence the question if it's a (unknown) feature or a bug :).

If it is a feature (which I'm all for) then we should update the UI to make it explicit that it's possible to drag it around, and expand the draggable region.

I think the latest UI elements in Windows 10(X) use the rectangle in the title bar to indicate that the window is draggable. Should be an easy add.

image

But where should we place it within the launcher ui? We don't have a title bat where we have space for that.

@niels9001 niels9001 added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Oct 7, 2020
@crutkas
Copy link
Member

crutkas commented Oct 7, 2020

This is chances are legacy from Wox, i don't believe it should be draggable.

#4576 is an issue asking for it to be settable.

@crutkas crutkas added Priority-3 Bug that is low priority and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 7, 2020
@Zotyamester
Copy link

Zotyamester commented Oct 28, 2020

I did some research and found the code that implements this dragging behaviour.
MainWindow.xaml.cs
If it should not be draggable, we can just delete these lines and we're good to go.

Personal opinion: It would be kinda nice to have an option in PowerToys settings to change the position of the window.

@enricogior
Copy link
Contributor

@Zotyamester
thank you for looking into this.

@crutkas crutkas added the Planning-Consideration Consideration for 2021 stability release label Dec 15, 2020
@stefan-schweiger
Copy link

stefan-schweiger commented Dec 16, 2020

Please don't remove the ability to drag it around. When I use it as a calculator I often need to be able to see information below and it makes life so much easier if you can change the position. Spotlight under macos works the same way.

Should it be configurable? Yes probably. But I also still miss the ability to save the last position (it's in the code but not in the settings gui)

@crutkas
Copy link
Member

crutkas commented Dec 31, 2020

lets dup this against #4576

@crutkas crutkas closed this as completed Dec 31, 2020
@crutkas crutkas added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Planning-Consideration Consideration for 2021 stability release Priority-3 Bug that is low priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

6 participants