Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT Keyboard mannager] Crash when remapping shortcut #6955

Closed
wicusbester opened this issue Oct 1, 2020 · 4 comments
Closed

[PT Keyboard mannager] Crash when remapping shortcut #6955

wicusbester opened this issue Oct 1, 2020 · 4 comments
Assignees
@arjunbalgovind
Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11ySev1 Accessibility team tag - P1 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)
Milestone
InVEST-2010

Comments

@wicusbester
Copy link

keyboard manager crash.zip
When I tried to remap a shortcut but accidentally pressed the wrong keys, PT crashed. I recreated the issue and attached a steps recorder file. It may have been because the shortcut didn't exist. on version 0.23.0
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 1, 2020
@arjunbalgovind
Copy link
Contributor

I can repro this. @ryanbodrug-microsoft @crutkas FYI, might be a good hotfix item if its an easy fix

@arjunbalgovind arjunbalgovind added Issue-Bug Something isn't working Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager labels Oct 1, 2020
@crutkas
Copy link
Member

crutkas commented Oct 1, 2020

Look into it and see if we can't get a hotfix out.

@crutkas crutkas added Priority-0 Bugs that we consider release-blocking/recall-class (P0) and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 1, 2020
@crutkas crutkas added this to the InVEST-2010 milestone Oct 1, 2020
@crutkas crutkas changed the title [PT Keyboard mannager] Chash when remapping shortcut [PT Keyboard mannager] Crash when remapping shortcut Oct 1, 2020
@arjunbalgovind arjunbalgovind mentioned this issue Oct 1, 2020
Merged
3 tasks
@arjunbalgovind arjunbalgovind added the Status-In progress This issue or work-item is under development label Oct 1, 2020
@crutkas crutkas added the Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT) label Oct 2, 2020
@arjunbalgovind arjunbalgovind added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Hot Fix Items we will product an out-of-band release for and removed Status-In progress This issue or work-item is under development labels Oct 2, 2020
@arjunbalgovind arjunbalgovind mentioned this issue Oct 6, 2020
Closed
@crutkas
Copy link
Member

crutkas commented Oct 9, 2020

Fixed in https://github.com/microsoft/PowerToys/releases/tag/v0.23.2

@crutkas crutkas closed this as completed Oct 9, 2020
@crutkas crutkas mentioned this issue Oct 15, 2020
Closed
@crutkas crutkas added the A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft label Oct 15, 2020
@crutkas
Copy link
Member

crutkas commented Oct 15, 2020

Labeling E+D since #7023 was their tracking issue that we dup'ed this against

@Priyanshu073 Priyanshu073 added A11ySev1 Accessibility team tag - P1 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunbalgovind arjunbalgovind

Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11ySev1 Accessibility team tag - P1 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)
Projects
None yet
Milestone
InVEST-2010
Development

No branches or pull requests
4 participants
@crutkas @arjunbalgovind @wicusbester @Priyanshu073