-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PowerToys Run] Searching without using accented characters should bring accentuated results too #4147
Comments
What will be find if you search for a win32 application with accent in the name. I think they must be found. Because for packaged apps only the localized name is available for search and on win32 applications it's the other way. See #4146. |
I will check later and give a feedback. But I think it should match acented characters in any of the two names. For example, "settings" translates to "configurações" in Brazilian Portuguese, and finding it by searching for a substring of "configuracoes" is desirable as it's faster to type without the accents. Windows Search does that. Edit: |
the work here would be in the program plugin. I'd be surprised if there wasn't some type of "best practice" here for this scenario |
https://twitter.com/drosenwasser/status/1324501630390206464?s=21 has how we should pivot the query |
@wazybr |
@enricogior |
@enricogior |
From the twitter earlier: string.Compare(s1, s2, CultureInfo.CurrentCulture, CompareOptions.IgnoreNonSpace | CompareOptions.IgnoreCase); |
Fixed with 0.29, released today. https://github.com/microsoft/PowerToys/releases/tag/v0.29.0 |
Environment
Steps to reproduce
Expected behavior
The shortcut with accented characters in it's name should be displayed as a result, as Windows Search does.
Actual behavior
The shortcut with accented characters isn't one of the results.
Screenshots
Expected behavior:
Actual behavior:
The text was updated successfully, but these errors were encountered: