Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tracker] OS Detection flaw in 0.18 #3354

Closed
crutkas opened this issue May 20, 2020 · 3 comments
Closed

[tracker] OS Detection flaw in 0.18 #3354

crutkas opened this issue May 20, 2020 · 3 comments
Labels
Priority-0 Bugs that we consider release-blocking/recall-class (P0)
Milestone
Stability Release

Comments

@crutkas
Copy link
Member

crutkas commented May 20, 2020 •
edited
Loading

This is the master tracking item for OS detection flaws.

We seeing items failing to launch since the OS detection code doesn't seem to be reacting appropriately.

Bug # title
#3322 Stopped Working Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication or EdgeManager.dll
#3152 [settings] able to pull up old and new settings dialog at same time
#3579 centralize OS detection in the runner
#3925 PowerToys Run & Keyboard Manager Off on Windows 10 2004 (10.0.19041.264)
#3730 PT Run should not try to start on 1809 and earlier
#4334 PowerLauncher has stopped working
@crutkas crutkas added the Hot Fix Items we will product an out-of-band release for label May 20, 2020
@crutkas crutkas added this to the v1.0 Release milestone May 20, 2020
@enricogior enricogior mentioned this issue May 21, 2020
Closed
1 task
@crutkas crutkas mentioned this issue May 22, 2020
Closed
@jyuwono jyuwono changed the title OS Detection flaw in 0.18 [tracker] OS Detection flaw in 0.18 May 28, 2020
@jyuwono jyuwono added Priority-0 Bugs that we consider release-blocking/recall-class (P0) and removed Hot Fix Items we will product an out-of-band release for labels Jun 1, 2020
@arjunbalgovind arjunbalgovind mentioned this issue Jun 11, 2020
Merged
2 tasks
@crutkas
Copy link
Member Author

crutkas commented Jun 17, 2020

added #4334

@enricogior
Copy link
Contributor

adding reference to #4432

@enricogior
Copy link
Contributor

enricogior commented Jun 29, 2020 •
edited
Loading

Proposed fix in #4432 (comment)

@crutkas crutkas closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority-0 Bugs that we consider release-blocking/recall-class (P0)
Projects
None yet
Milestone
Stability Release
Development

No branches or pull requests
3 participants
@crutkas @enricogior @jyuwono