[Run][Shell plugin] Add setting or action char to don't close command prompt after

[htcfreek]

Summary of the new feature/enhancement

If I execute ipconfig via PowerToys Run > ipconfig the command window close itself directly after executing. But the ipconfig output has to stay open, so that I can read them.

We need a setting and/or character to tell the shell plugin to not close the window after executing the command.

Proposed technical implementation details (optional)

Character
>> ipconfig

Setting
[ ] Don't close the shell window after executing the command

Requires #5273 to be done first.

[PhilTb7]

I think 99% of the time I run a command in the shell I want to see the output. This should be default.

[htcfreek]

@jyuwono I think this should be a must have for v0.19.

[crutkas]

while i agree, this is how run prompt works

[htcfreek]

while i agree, this is how run prompt works

Maybe we need different the two tools 'shell' and 'run'.

[crutkas]

I think the better way to view this is "we can do better than run prompt"

Start menu also executes this command correctly

[htcfreek]

Start menu also executes this command correctly

That's new for me. Didn't know that. Thank you for that tipp.

[muzam1l]

Currently, Whenever I want to see the output of a command like ipconfig, I do something like this > cmd /k ipconfig (or > cmd /c ipconfig & pause ). Also, there is an issue with commands, which take little longer to execute that they don't get executed at all (like adb connect <host> in my case, sometimes), so have to do something like this > cmd /c adb connect <host> which terminates console after completing command as supposed (current behavior doesn't wait much!). But yeah there should be a cleaner way to do these things added by default.

[micahmo]

Currently, Whenever I want to see the output of a command like ipconfig, I do something like this > cmd /k ipconfig

Yes, this is a good workaround, and a good argument for adding a special character to simulate the cmd /k part. Even if I have to type double characters (e.g., >>, as @htcfreek suggested) every time I want the shell to stay open, it's still faster than cmd /k.

Also, if there is a new setting to choose the default behavior, the alternate character should do the opposite.

For example, if I want to keep the shell open 99% of the time, like @olovsson, I'll choose the option Don't close the shell window after executing the command. Then the > character keeps it open, and the >> character closes it.

[htcfreek]

@crutkas
Should we mark this as help wanted?

[enricogior]

I think we need to do it, since for some commands, not having this option means the command is useless when invoked from PT Run.

@alannt777 please don't downvote a community upvote.

[ghost]

@enricogior I downvoted him because he used a +1 comment instead of a reaction.

[enricogior]

@alannt777
explaining that an issue can be upvoted with a reaction is useful, downvoting it is not.

[crutkas]

this really needs the plug setting UX. I think it is a good setting

[htcfreek]

@davidegiacometti
This could be implemented by a simple true/false setting "Don't close shell window". Thoughts?

Btw. the setting (LeaveShellOpen) exists in the plugin and maybe only needs to ne added to ui.

[davidegiacometti]

@davidegiacometti
This could be implemented by a simple true/false setting "Don't close shell window". Thoughts?

Btw. the setting (LeaveShellOpen) exists in the plugin and maybe only needs to ne added to ui.

Not really sure.. I think this will need further investigation.

• Shell plugin can handle these configurations.
• But is using a different config file %LOCALAPPDATA%\Microsoft\PowerToys\PowerToys Run\Settings\Plugins\Microsoft.Plugin.Shell\ShellPluginSettings.json.
• In the current state plugin manager can manage only boolean options.

[htcfreek]

/dup #10259

[microsoft-github-policy-service]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!