Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] Intro / exit animations #2191

Open
crutkas opened this issue Apr 17, 2020 · 23 comments
Open

[Run] Intro / exit animations #2191

crutkas opened this issue Apr 17, 2020 · 23 comments
Labels
Area-User Interface things that regard UX for PowerToys External Dependency-WinUI 3 Dependency on WinUI Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Status-Blocked We can't make progress due to a dependency or issue

Comments

@crutkas
Copy link
Member

crutkas commented Apr 17, 2020

right now it is Visible / not visible. We need a quick, fade in / out.

Same should be list results.

  1. Guessing, .66 sec for fade in / out. Snappy but not slow.
  2. This has to be handled on WPF side due to WinUI transparency issues.
@crutkas crutkas added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Apr 17, 2020
@crutkas crutkas added this to the Build 2020 milestone Apr 17, 2020
@crutkas
Copy link
Member Author

crutkas commented Apr 17, 2020

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

Looks like we can't do this right now. note this was with .1 on both window and island ... hmmm

image

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

image
another shot

@dsrivastavv
Copy link
Contributor

@crutkas Fading is working for WPF elements but not for XAMLIsland objects. I have the code here : https://github.com/somil55/PowerToys/tree/somil55/LauncherFading. I think it should probably be because of xaml island transparency issue.

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

I gave an idea here.

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

Fade in wpf (50ms)
Make island visible
Fade in text on control (33ms)

Lot more complex. BUT should work. Going to have to do a lot of tweaking for timing.

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

Or 33 and 33

@JordanAnthonyKing
Copy link
Contributor

This will need to respect the OS level enable/disable animations setting.

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

It won’t since it is in memory

@niels9001
Copy link
Contributor

Are we still planning to have a dark semi-transparent backdrop (like Shortcuts Guide)? We might want to do a quick fade there as well.

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

As of now, no. Only shortcut guide.

@niels9001
Copy link
Contributor

niels9001 commented Apr 18, 2020

As of now, no. Only shortcut guide.

We need to make sure that there's enough contrast between the control and the background then:
image

But having a dropshadow should solve that in case we don't have the backdrop.

@crutkas
Copy link
Member Author

crutkas commented Apr 18, 2020

It should but this was me showing the xaml islands can’t fade in with opacity.

@jyuwono jyuwono removed the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label Apr 21, 2020
@jyuwono jyuwono modified the milestones: Build 2020, v1.0 Release Apr 21, 2020
@niels9001
Copy link
Contributor

@crutkas @somil55

For the WPF branch, what would be the best approach:

  • Intro animation (XAML Storyboard- getting called on the short keystroke event)
  • Outro animation (XAML Storyboard with a Completed event. Gets called in the OnDeactivated function - runs the SB and when Completed calls Hide()?

@niels9001
Copy link
Contributor

niels9001 commented May 27, 2020

Here's a first shot at it.

Single bar:
SingleBar

With results:
ResultsBar

With results the framerate seems to drop slightly. Need to optimize the animations though, opacity animations are maybe not needed.

@crutkas
Copy link
Member Author

crutkas commented May 27, 2020

can we have results do a downward motion? or maybe results do downward only if there is a single bar?

also ... as always ... 🔥🔥🔥🔥🔥

@dsrivastavv
Copy link
Contributor

I found the potential issue with animations. Here is what seems to happen :

  1. Main windows is set to visible and the window is shown with opacity 1.
  2. Storyboard is started with opacity 0. This cause a flashing as there is sudden change from 1 to 0 in opacity

WPFAnimation

@niels9001
Copy link
Contributor

@somil55 What I don't understand, if I set the Opacity of the root grid to 0 in Deactivate() everything should work fine, right? Still getting the same issue. Is Activate() causing UI elements to show as opacity = 1 for some reason?

@dsrivastavv
Copy link
Contributor

@niels9001 I checked opacity before activate and it was 1. So, I don't think Activate() is causing it.

@niels9001
Copy link
Contributor

@niels9001 I checked opacity before activate and it was 1. So, I don't think Activate() is causing it.

Right. So if you set Opacity = 0 just before Hide() it doesn't get saved. Whenever you press Alt+Space Opacity is 1 again.

@crutkas
Copy link
Member Author

crutkas commented Jun 8, 2020

newb q, does this behavior happen on a self contained app or is behavior unique to PT Run

@crutkas crutkas added the Status-Blocked We can't make progress due to a dependency or issue label Aug 25, 2020
@crutkas
Copy link
Member Author

crutkas commented Aug 25, 2020

blocked by #4030

@nithssh
Copy link

nithssh commented Oct 25, 2020

Also It would be great if the search bar also darkened the rest of the screen very subtly, cuz right now, it's very hard to separate it from the background in most cases.

image

Edit: I just saw that others are mentioning the same thing above, but I'll leave this comment in to show there is a demand for it from the userbase too :)

@crutkas crutkas removed this from the 2020 Stability Release milestone Dec 7, 2020
@enricogior enricogior changed the title [Launcher] - intro / exit animations [Run] Intro / exit animations Jan 9, 2021
@enricogior enricogior added Idea-Enhancement New feature or request on an existing product External Dependency-WinUI 3 Dependency on WinUI labels Jan 9, 2021
@enricogior enricogior added the Area-User Interface things that regard UX for PowerToys label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys External Dependency-WinUI 3 Dependency on WinUI Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Status-Blocked We can't make progress due to a dependency or issue
Projects
None yet
Development

No branches or pull requests

7 participants