Validate launcher - Window Walker reacts to winkey + mouse button

[savchenko]

Environment

Windows build number: 10.0.18363.720
PowerToys version: v0.16.1
PowerToy module for which you are reporting the bug (if applicable): Window Walker

Steps to reproduce

1. Launch PowerToys with WindowWalker module enabled
2. Launch https://github.com/stefansundin/altdrag (Alt+Drag or Windows+Drag to move windows #269) that is using Winkey as the "control key".
3. Observe WindowWalker appearing when winkey+mouse button are pressed.

Expected behavior

1. WindowWalker should not pop-up unless ctrl+win are pressed simultaneously.
2. WindowWalker should not react to mouse button events

Actual behavior

1. WindowWalked pops-up when winkey+mouse button are pressed.

Screenshots

N/A, happy to supply a screen recording if needs be.

[crutkas]

i think we should validate this with launcher since WW will migrate over

[savchenko]

Thanks, I will test with https://github.com/microsoft/PowerToys/milestone/9 once it is released.

[crutkas]

@asvc, does this work?

[savchenko]

@crutkas,
Downloaded v0.19.1. Would it be safe to assume that "WindowWalker" was renamed to the "PowerToys Run"? In that case it doesn't work with AltDrag, no new interfaces appear on the hotkey press. Changing the shortcut (I have tried alt+shift+space) makes no difference.

AltDrag is built from https://github.com/asvc/altdrag

[crutkas]

looking at AltDrag, it is GPLv3 so we can't look at source code which could make debugging hard. We're just using standard hooks here as are the other included utilities.

so even with 0.19, you hit winkey+mouse and it triggers?

[crutkas]

@betsegaw window walker used a standard .net keyhook, right?

[betsegaw]

@crutkas Window Walker used the "RegisterHotKey" win32 API.

It adds a hook to look at windows messages and checks for a specific message.

[savchenko]

looking at AltDrag, it is GPLv3 so we can't look at source code

@stefansundin , would you consider releasing under MIT, etc?

so even with 0.19, you hit winkey+mouse and it triggers?

@crutkas , using v0.19.1: "PowerToys Run" search bar doesn't appear after pressing an assigned hotkey while AltDrag is running.

[crutkas]

@asvc, We're using standard keyhooks inside windows. They also do reg hacks it seems like and that could interfere based on the installer.

I did just install and try with an internal testing build for 0.20 and everything seems to work correctly.

[savchenko]

@crutkas , I don't see v0.20 at https://github.com/microsoft/PowerToys/releases, is it from AppVeyor / etc?..

[crutkas]

.20 will be released this month. We are testing internally. (Or you can clone master and build it yourself :))

[crutkas]

@asvc we just released it on friday.

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

[savchenko]

Just wanted to confirm that v0.20.1 works fine and AltDrag isn't affected by FancyZones. Thanks @crutkas !