[PT Run] Calculator logs exception on some invalid queries

[htcfreek]

https://github.com/microsoft/PowerToys/blob/main/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/Main.cs#L31-L34

This code above causes exceptions in the log file that say = or <query> is not a valid operation that can be parsed.

We should simply return List<Result>(0) if query is empty, null, whitespace, equals the action key or equals =.

[htcfreek]

@jaimecbernardo
I going to upload the log file later this evening.

[jaimecbernardo]

Sounds good 👍 Thank you

[htcfreek]

Log and the settings file:
calc-bugs.zip

PowerToys version: 0.56.2

If only action char is entered and search term is empty:

[2022-03-27 21:24:38.0161] [ERROR] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::215]
-------------------------- Begin exception --------------------------
Message: Exception for plugin <Calculator> when query <=>

Exception full name  : System.ArgumentNullException
Exception message    : Value cannot be null. (Parameter 'input')
Exception stack trace:
   at Microsoft.PowerToys.Run.Plugin.Calculator.CalculateHelper.InputValid(String input)
   at Microsoft.PowerToys.Run.Plugin.Calculator.Main.Query(Query query)
   at PowerLauncher.Plugin.PluginManager.<>c__DisplayClass22_0.<QueryForPlugin>b__0()
   at Wox.Infrastructure.Stopwatch.Debug(String message, Action action)
   at PowerLauncher.Plugin.PluginManager.QueryForPlugin(PluginPair pair, Query query, Boolean delayedExecution)
Exception source     : Microsoft.PowerToys.Run.Plugin.Calculator
Exception target site: Boolean InputValid(System.String)
Exception HResult    : -2147467261
-------------------------- End exception --------------------------

If input is invalid and converted to an string error message in Interpret() method:

[2022-03-27 21:48:22.9261] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.Calculator\Main.cs::64]
-------------------------- Begin exception --------------------------
Message: Exception when query for <{query}>

Exception full name  : System.FormatException
Exception message    : Input string was not in a correct format.
Exception stack trace:
   at System.Number.ThrowOverflowOrFormatException(ParsingStatus status, TypeCode type)
   at System.Convert.ToDecimal(String value, IFormatProvider provider)
   at System.String.System.IConvertible.ToDecimal(IFormatProvider provider)
   at System.Convert.ToDecimal(Object value, IFormatProvider provider)
   at Microsoft.PowerToys.Run.Plugin.Calculator.CalculateEngine.Interpret(String input, CultureInfo cultureInfo)
   at Microsoft.PowerToys.Run.Plugin.Calculator.Main.Query(Query query)
Exception source     : System.Private.CoreLib
Exception target site: Void ThrowOverflowOrFormatException(ParsingStatus, System.TypeCode)
Exception HResult    : -2146233033
-------------------------- End exception --------------------------

Happens on invalid expressions:

[2022-03-27 21:53:58.8246] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.Calculator\Main.cs::64]
-------------------------- Begin exception --------------------------
Message: Exception when query for <{query}>

Exception full name  : Mages.Core.ParseException
Exception message    : The given source code contains errors.
Exception stack trace:
   at Mages.Core.Ast.Walkers.OperationTreeWalker.Mages.Core.Ast.IValidationContext.Report(ParseError error)
   at Mages.Core.Ast.Expressions.InvalidExpression.Validate(IValidationContext context)
   at Mages.Core.Ast.Walkers.OperationTreeWalker.Mages.Core.Ast.ITreeWalker.Visit(InvalidExpression expression)
   at Mages.Core.Ast.Expressions.InvalidExpression.Accept(ITreeWalker visitor)
   at Mages.Core.Ast.Walkers.OperationTreeWalker.Mages.Core.Ast.ITreeWalker.Visit(ArgumentsExpression expression)
   at Mages.Core.Ast.Walkers.OperationTreeWalker.Mages.Core.Ast.ITreeWalker.Visit(CallExpression expression)
   at Mages.Core.Ast.Walkers.OperationTreeWalker.Mages.Core.Ast.ITreeWalker.Visit(BlockStatement block)
   at Mages.Core.Ast.StatementExtensions.MakeRunnable(IEnumerable`1 statements)
   at Mages.Core.Engine.Interpret(String source)
   at Microsoft.PowerToys.Run.Plugin.Calculator.CalculateEngine.Interpret(String input, CultureInfo cultureInfo)
   at Microsoft.PowerToys.Run.Plugin.Calculator.Main.Query(Query query)
Exception source     : Mages.Core
Exception target site: Void Mages.Core.Ast.IValidationContext.Report(Mages.Core.ParseError)
Exception HResult    : -2146233088
-------------------------- End exception --------------------------

If query is =[10,10]:

[2022-03-27 21:55:25.3373] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.Calculator\Main.cs::64]
-------------------------- Begin exception --------------------------
Message: Exception when query for <{query}>

Exception full name  : System.InvalidCastException
Exception message    : Unable to cast object of type 'System.Double[,]' to type 'System.IConvertible'.
Exception stack trace:
   at System.Convert.ToDecimal(Object value, IFormatProvider provider)
   at Microsoft.PowerToys.Run.Plugin.Calculator.CalculateEngine.Interpret(String input, CultureInfo cultureInfo)
   at Microsoft.PowerToys.Run.Plugin.Calculator.Main.Query(Query query)
Exception source     : System.Private.CoreLib
Exception target site: System.Object ChkCast_Helper(Void*, System.Object)
Exception HResult    : -2147467262
-------------------------- End exception --------------------------

Happens if result is to large for the decimal type:

[2022-03-27 23:23:07.3322] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.Calculator\Main.cs::64]
-------------------------- Begin exception --------------------------
Message: Exception when query for <{query}>

Exception full name  : System.OverflowException
Exception message    : Value was either too large or too small for a Decimal.
Exception stack trace:
   at System.Number.ThrowOverflowException(TypeCode type)
   at System.Decimal.DecCalc.VarDecFromR8(Double input, DecCalc& result)
   at System.Double.System.IConvertible.ToDecimal(IFormatProvider provider)
   at Microsoft.PowerToys.Run.Plugin.Calculator.CalculateEngine.Interpret(String input, CultureInfo cultureInfo)
   at Microsoft.PowerToys.Run.Plugin.Calculator.Main.Query(Query query)
Exception source     : System.Private.CoreLib
Exception target site: Void ThrowOverflowException(System.TypeCode)
Exception HResult    : -2146233066
-------------------------- End exception --------------------------

[htcfreek]

@jaimecbernardo
For easier debugging we should fix log command to show the real query:

Exception when query for <{query}>

[jaimecbernardo]

Nice to have. Doesn't impact the user much, but would help in debugging in the future.

[jaimecbernardo]

Perhaps an actual error result when Calculator is called with keyword would be nice as well.

[htcfreek]

Perhaps an actual error result when Calculator is called with keyword would be nice as well.

Should this show the error message from exception in subtitle?

[htcfreek]

Released with v0.59.0