Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] Mouse hover color enhancement #10441

Closed
dougwl opened this issue Mar 25, 2021 · 7 comments
Closed

[Run] Mouse hover color enhancement #10441

dougwl opened this issue Mar 25, 2021 · 7 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@dougwl
Copy link

dougwl commented Mar 25, 2021

Environment

PowerToys v0.33.1 (DarkMode On)
Windows 10 - 20h2

Steps to reproduce

Make any search with more than one result in PT Run, the keyboard selected option will have the same color as the item hovered by the mouse.

Expected behavior

It would be nice to have a distinction between the colors of the selection and the mouse hover, or maybe additionally even hide the mouse hover when you start navigating using the keyboard.

Actual behavior

The colors are the same.

Screenshot

image

@dougwl dougwl added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Mar 25, 2021
@niels9001 niels9001 added the Area-User Interface things that regard UX for PowerToys label Mar 25, 2021
@mykhailopylyp mykhailopylyp added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Mar 26, 2021
@crutkas
Copy link
Member

crutkas commented Apr 1, 2021

@dougwl What is your system's accent color? On my system, my highlight is blue which corisponds to selected and mouse hover is grey, I tested on light and dark mode and both worked as expected

@crutkas crutkas added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 1, 2021
@crutkas
Copy link
Member

crutkas commented Apr 1, 2021

  • I'm on 0.35, fyi

@dougwl
Copy link
Author

dougwl commented Apr 1, 2021

Hi, @crutkas, thanks for looking into my suggestion.
So, I've updated to 0.35 to be safe and changed my accent color, and yes that does change the selection color as can be seen in the screenshot below, but if I want to keep my current color or any other similar, I'm bound to keep having this problem.

Maybe, this can be solved making the mouse hover based on a gradient between the current accent and the default one from PT Run?
Luminance or analagous colors are other options, since this would avoid problems if the two colors are very similar.


image


image


image

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 1, 2021
@dougwl
Copy link
Author

dougwl commented Apr 1, 2021

@crutkas
Copy link
Member

crutkas commented Apr 2, 2021

In light mode, it is near impossible it seems like to get into trouble BUT this really shows up in dark mode but we're following base WinUI guidance for how colors work in dark mode.

@crutkas crutkas removed Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 2, 2021
@crutkas
Copy link
Member

crutkas commented Apr 2, 2021

Seeing where this feedback needs to be directed

@crutkas crutkas self-assigned this Apr 2, 2021
@niels9001 niels9001 self-assigned this Jun 5, 2021
@niels9001 niels9001 removed their assignment Oct 11, 2021
@niels9001 niels9001 self-assigned this Sep 12, 2023
@niels9001 niels9001 mentioned this issue Sep 13, 2023
11 tasks
@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Nov 7, 2023
@niels9001
Copy link
Contributor

This was fixed with the redesign of Run

@niels9001 niels9001 added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

4 participants