Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerRename] - Detect when pattern matching is used and suggest checking "match all" #1002

Closed
crutkas opened this issue Dec 21, 2019 · 5 comments
Labels
Area-User Interface things that regard UX for PowerToys Idea-Enhancement New feature or request on an existing product Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@crutkas
Copy link
Member

crutkas commented Dec 21, 2019

due to #980 and #881, it may be helpful to inform user that they may need to enable 'match all' if we detect pattern matching like $1, $2 in the replace text box

@crutkas crutkas added Idea-Enhancement New feature or request on an existing product Product-PowerRename Refers to the PowerRename PowerToy Area-User Interface things that regard UX for PowerToys labels Dec 21, 2019
@crutkas crutkas changed the title Detect when pattern matching is used and suggest checking "match all" [PowerRename] - Detect when pattern matching is used and suggest checking "match all" Dec 21, 2019
@rakusan2
Copy link

Isn’t the match all option meant for matching all occurrences of the pattern?
In previous versions it worked that without the option it only matched the first.
Has this been changed?

@crutkas
Copy link
Member Author

crutkas commented Dec 21, 2019

Without that option enabled, the feature doesn’t work. Either a bug there or label is messed up.

@crutkas
Copy link
Member Author

crutkas commented Dec 23, 2019

Isn’t the match all option meant for matching all occurrences of the pattern?
In previous versions it worked that without the option it only matched the first.
Has this been changed?

In 14.1, it only returns first instance. That is with/without regex enabled. The reason why you are able to do the more complex $1 and $2 is due to regex's pattern matching once that option is enabled.

@riverar
Copy link
Contributor

riverar commented Jun 3, 2020

Match All Occurrences doesn't make sense in scenarios such as #4011

@muratakburak muratakburak added the Status-In progress This issue or work-item is under development label Jun 6, 2020
@enricogior enricogior added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jun 16, 2020
@crutkas
Copy link
Member Author

crutkas commented Jun 30, 2020

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Idea-Enhancement New feature or request on an existing product Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants