Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate SignatureAnalysis without using GetExpressionRange #3171

Closed
zooba opened this issue Oct 18, 2017 · 2 comments
Closed

Generate SignatureAnalysis without using GetExpressionRange #3171

zooba opened this issue Oct 18, 2017 · 2 comments
Labels
Technical Debt

Comments

@zooba
Copy link
Member

zooba commented Oct 18, 2017

As part of #3166 we are removing uses of GetExpressionRange. The only remaining uses are analyzing signatures to find the current parameter, which does not have an equivalent yet.

We should update signature analysis to not need this function.
zooba added a commit to zooba/PTVS that referenced this issue Oct 18, 2017
@zooba
Deprecates GetExpressionRange function.
70e075a 
Suppresses warnings for existing uses (see microsoft#3171)
@zooba zooba mentioned this issue Oct 25, 2017
Merged
@zooba
Copy link
Member Author

zooba commented Mar 17, 2018 •
edited
Loading

This also selects the wrong parameter index in code like this:

f((1, 2, 3

@zooba zooba mentioned this issue Mar 21, 2018
Closed
@MikhailArkhipov MikhailArkhipov mentioned this issue Mar 21, 2018
Closed
5 tasks
@MikhailArkhipov MikhailArkhipov mentioned this issue Mar 28, 2018
Merged
5 tasks
@huguesv
Copy link
Contributor

huguesv commented May 11, 2020

Improvement no longer relevant.

@huguesv huguesv closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zooba @huguesv