Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 - inspect for mutations in serialization methods #2080

Open
baywet opened this issue Jan 22, 2025 · 0 comments
Open

v2 - inspect for mutations in serialization methods #2080

baywet opened this issue Jan 22, 2025 · 0 comments
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience

Comments

@baywet
Copy link
Member

baywet commented Jan 22, 2025

in #2079 I've fixed a but where the serialization code was mutating the object.
This is an issue since if you serialize the same object multiple times, you might get different results. (or depending on the ordering v2/v3)

We should inspect all serialization methods to ensure there are no more mutations of the properties, sub-objects in the serialization code.

@baywet baywet added priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience
Projects
None yet
Development

No branches or pull requests

1 participant