-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated CI Pipeline #118
Conversation
Packaging Pipeline Automation
rename task rename task
…MixedReality-GraphicsTools-Unity into user-tayomadein-ci-cd
Pipelines/ci.yaml
Outdated
trigger: | ||
tags: | ||
include: | ||
- '*' | ||
branches: | ||
exclude: | ||
- main | ||
- user-tayomadein-ci-cd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea here to only run this when a tag is created? Or is there also the goal of running on every merge or something?
I'm mostly wondering about the explicit exclusion of main
. Is there a specific branch that's used for releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the goal here is to run the pipeline only when a tag is created, running on every merge to main will make the publish task for the job fail and it will be failing because the package name will already exist in the pipeline.
Currently, main is used for releases, I am looking to include a flow that only recognizes tags as the release. What do you think about this approach.?
Pipelines/ci.yaml
Outdated
|
||
- checkout: PipelineTools | ||
|
||
- pwsh: Write-Host "##vso[build.updatebuildnumber]$(MRTKGraphicsToolsVersion)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will $(MRTKGraphicsToolsVersion)
change for each run? If not, you might want to update this to make the build number unique. If it will, then no problem!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current plan is to run for tags, in that case, $(MRTKGraphicsToolsVersion) will change for each run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, thanks for getting this PR up so quickly! I've added @keveleigh as a reviewer since I'm not versed in PowerShell/YAML or how our pipelines work.
Pipelines/Config/settings.yaml
Outdated
# Note that when updating this value also ensure that you update the | ||
# following locations to match. There will be a CI failure if they don't | ||
# match (see scripts/packaging/versionmetadata.ps1) | ||
# ProjectSettings/ProjectSettings.asset: bundleVersion: x.x.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain this requirement? Do we need to update the bundleVersion and metroPackageVersion when we change the MRTKGraphicsToolsVersion?
- '*' | ||
branches: | ||
exclude: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm not familiar with this syntax. Does this mean these branches are not considered for the trigger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my goal is to exclude main from the trigger so it doesn't run for every merge to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, that makes sense. I wonder if we need to exclude "all branches" and only look for when tags change?
3fb016a
to
83327bb
Compare
83327bb
to
9cc1f4b
Compare
test exclude remove settings usage test version Update ci.yaml Update ci.yaml Update ci.yaml
9cc1f4b
to
f83a3cb
Compare
Closing since this is no longer needed. |
Overview
An automated ADO pipeline to push to the MR GraphicsTool package to MRTK NPM feed
Changes
Verification (Before Merge)
Post-merge tasks
Verification (After Merge)