Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamsTenantDialPlan: NormalizationRules is not being properly inserted in the blueprint #4428

Closed
ricmestre opened this issue Mar 8, 2024 · 0 comments · Fixed by #4429 or #4512
Closed
Assignees
Labels
Bug Something isn't working Core Engine DSCParser Issues related to DSCParser

Comments

@ricmestre
Copy link
Contributor

Description of the issue

The property NormalizationRules from resource TeamsTenantDialPlan is not being properly inserted in the blueprint, the blueprint may still be able to be compiled into MOF but using ConvertTo-DSCObject on it, which I require in my internal solution, will get confused and the object of that resource, specifically on that property, will not be extracted correctly.

The fix is to make the required changes to function Get-M365DSCNormalizationRulesAsString so that it outputs the property correctly, will try to make a PR for this.

Microsoft 365 DSC Version

1.24.228.1

Which workloads are affected

Teams

The DSC configuration

TeamsTenantDialPlan "TeamsTenantDialPlan-REDACTED"
        {
            Credential            = $Credscredential;
            Description           = "REDACTED";
            Ensure                = "Present";
            Identity              = "REDACTED";
            NormalizationRules    = @(MSFT_TeamsVoiceNormalizationRule{
                Pattern = '^(\d+)$'
                Description = 'Keep All'
                Identity = 'Keep All'
                Translation = '$1'
                IsInternalExtension = $False
            }MSFT_TeamsVoiceNormalizationRule{
                Pattern = '^([2-8]\d{7})$'
                Description = 'DK 8 Digit'
                Identity = 'DK 8 Digit'
                Translation = '+45$1'
                IsInternalExtension = $False
            }MSFT_TeamsVoiceNormalizationRule{
                Pattern = '^0([2-8]\d{7})$'
                Description = 'DK 8 Digit with 0'
                Identity = 'DK 8 Digit with 0'
                Translation = '+45$1'
                IsInternalExtension = $False
            }MSFT_TeamsVoiceNormalizationRule{
                Pattern = '^(1\d{1}\d+)$'
                Description = 'DK Service'
                Identity = 'DK Service'
                Translation = '$1'
                IsInternalExtension = $False
            }MSFT_TeamsVoiceNormalizationRule{
                Pattern = '^0?00(\d*)$'
                Description = 'International with 00 or 000'
                Identity = 'International with 00 or 000'
                Translation = '+$1'
                IsInternalExtension = $False
            });
            OptimizeDeviceDialing = $False;
            SimpleName            = "REDACTED";
        }

Verbose logs showing the problem

N/A

Environment Information + PowerShell Version

OsName               : Microsoft Windows 11 Enterprise
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 22621.1.amd64fre.ni_release.220506-1250
OsLanguage           : en-US
OsMuiLanguages       : {en-US, en-GB}

Name                           Value
----                           -----
PSVersion                      5.1.22621.1778
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.1778
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Engine DSCParser Issues related to DSCParser
Projects
None yet
2 participants