Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning/confirmation dialogue to export.microsoft365dsc.com if user selects components that are not supported with selected authentication method #2210

Open
etec-masterofsynapse opened this issue Aug 23, 2022 · 5 comments
Labels
Documentation Enhancement New feature or request

Comments

@etec-masterofsynapse
Copy link

As the title says.

If a user of export.microsoft365dsc.com "blindly" selects Full in combination with Credentials, you, at minimum, would have to remove the components PlannerBucket, PlannerPlan and TeamsChannelTab to not also need an AAD Application to fully complete the export.

If the website would give a warning / confirmation dialogue stating the fact that the user selected components not fit for use with only the selected authentication type and gave the option to continue (if the user specifically wants to also give an Application) or exclude problem components from the generated command (to not have to go to the shell with the full command, read the warning in the beginning, come back to the website and remove the components, regenerate and rerun), it would make this process easier.

Also, if a user already runs a script with components that need additional authentication methods, is there currently a way to skip that input step and continue without the additional method(s)?
If not, that would be another great addition, otherwise you would have to rerun a maybe already long-running export.

@andikrueger andikrueger added Enhancement New feature or request Documentation labels Aug 24, 2022
@andikrueger
Copy link
Collaborator

andikrueger commented Aug 25, 2022

Great idea. At the moment, we do not gather this information for the website.

There is additional work being made to improve the Export-M365DSCCconfiguration function and the handling of different authentication methods. See #2032 for more details.

@NikCharlebois
Copy link
Collaborator

Adding @sebastienlevert to the discussions. Not sure what the level of effort would be to determine this.

@etec-masterofsynapse
Copy link
Author

@NikCharlebois Since I assume the DSC script itself has the auth dependencies documented already, it would be a matter of translating that to the web backend for user display.

@sebastienlevert
Copy link
Collaborator

It's absolutely possible to update the schemas to disable some options based on the selections. @NikCharlebois, do we have a good mapping available? When we run the generation, we could update the code to take it in consideration.

@NikCharlebois
Copy link
Collaborator

Essentially, we would need to check in the resource's parameters list (the .psm1 files) to see if $CertificateThumbprint, $ApplicationSecret or $Credential are present and then make the decision based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants