From 146157697994dfe934fb0e7837c6585ecb792d65 Mon Sep 17 00:00:00 2001
From: Nik Charlebois <nik_charlebois@hotmail.com>
Date: Fri, 1 Nov 2024 09:20:28 -0400
Subject: [PATCH] AADServicePrincipal - Added Notes property

---
 CHANGELOG.md                                        |  2 ++
 .../MSFT_AADServicePrincipal.psm1                   | 13 +++++++++++++
 .../MSFT_AADServicePrincipal.schema.mof             |  1 +
 3 files changed, 16 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 72387c2c5a..9d8ecf03bc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -57,6 +57,8 @@
   * Initial release.
 * AADRoleManagementPolicyRule
   * Initial release.
+* AADServicePrincipal
+  * Added the notes field.
 * AADSocialIdentityProvider
   * Fixed missing permissions in settings.json
 * AADVerifiedIdAuthority
diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.psm1
index 836a91d7bf..3a7f3c653c 100644
--- a/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.psm1
+++ b/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.psm1
@@ -52,6 +52,10 @@ function Get-TargetResource
         [System.String]
         $LogoutUrl,
 
+        [Parameter()]
+        [System.String]
+        $Notes,
+
         [Parameter()]
         [System.String[]]
         $Owners,
@@ -311,6 +315,7 @@ function Get-TargetResource
                 ErrorUrl                           = $AADServicePrincipal.ErrorUrl
                 Homepage                           = $AADServicePrincipal.Homepage
                 LogoutUrl                          = $AADServicePrincipal.LogoutUrl
+                Notes                              = $AADServicePrincipal.Notes
                 Owners                             = $ownersValues
                 PublisherName                      = $AADServicePrincipal.PublisherName
                 ReplyURLs                          = $AADServicePrincipal.ReplyURLs
@@ -399,6 +404,10 @@ function Set-TargetResource
         [System.String]
         $LogoutUrl,
 
+        [Parameter()]
+        [System.String]
+        $Notes,
+
         [Parameter()]
         [System.String[]]
         $Owners,
@@ -768,6 +777,10 @@ function Test-TargetResource
         [System.String]
         $LogoutUrl,
 
+        [Parameter()]
+        [System.String]
+        $Notes,
+
         [Parameter()]
         [System.String[]]
         $Owners,
diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.schema.mof b/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.schema.mof
index 229f10d7c0..52ea7404ab 100644
--- a/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.schema.mof
+++ b/Modules/Microsoft365DSC/DSCResources/MSFT_AADServicePrincipal/MSFT_AADServicePrincipal.schema.mof
@@ -43,6 +43,7 @@ class MSFT_AADServicePrincipal : OMI_BaseResource
     [Write, Description("Specifies the error URL of the ServicePrincipal.")] String ErrorUrl;
     [Write, Description("Specifies the homepage of the ServicePrincipal.")] String Homepage;
     [Write, Description("Specifies the LogoutURL of the ServicePrincipal.")] String LogoutUrl;
+    [Write, Description("Notes associated with the ServicePrincipal.")] String Notes;
     [Write, Description("Specifies the PublisherName of the ServicePrincipal.")] String PublisherName;
     [Write, Description("List of the owners of the service principal.")] String Owners[];
     [Write, Description("The URLs that user tokens are sent to for sign in with the associated application, or the redirect URIs that OAuth 2.0 authorization codes and access tokens are sent to for the associated application.")] String ReplyUrls[];