Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify calling convention in get_model #306

Open
tcare opened this issue Jul 3, 2020 · 0 comments
Open

Unify calling convention in get_model #306

tcare opened this issue Jul 3, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@tcare
Copy link
Contributor

tcare commented Jul 3, 2020

As mentioned in #304, there is room for improvement with the calling convention of get_model. Some callers are expecting None if there is no model. Others expect an exception. We should standardize on a convention and allow for differentiation between no model and an infrastructure exception.
@shivp950 shivp950 added the enhancement New feature or request label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcare @shivp950