Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping support for python 3.8 and/or 3.9 #749

Open
bpkroth opened this issue May 21, 2024 · 1 comment
Open

Consider dropping support for python 3.8 and/or 3.9 #749

bpkroth opened this issue May 21, 2024 · 1 comment
Labels
low priority Low-priority issue

Comments

@bpkroth
Copy link
Contributor

bpkroth commented May 21, 2024

There may still be some deployment use cases for this so probably not just yet.

When we do get to it, don't forget to look for various sys.version_info checks to remove.

@bpkroth bpkroth added the low priority Low-priority issue label May 21, 2024
@bpkroth
Copy link
Contributor Author

bpkroth commented Oct 31, 2024

Could also modernize the way we do type hints (e.g., stop using Optional and Union)

@bpkroth bpkroth mentioned this issue Nov 22, 2024
bpkroth added a commit that referenced this issue Nov 25, 2024
# Pull Request

## Title

Additional fixups for the most recent versions of python/pylint.

---

## Description

- Converts some quote inconsistency ignores to `"""` strings
- Ignores a `Generator` typehint issue that changed with 3.13
- Adjusts a comment in pyproject.toml to help us track what needs to
change after dropping support for 3.8 - #749.

---

## Type of Change

- 🔄 Refactor

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Low-priority issue
Projects
None yet
Development

No branches or pull requests

1 participant