[#1336] Discard cached state after program starts stepping. #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the cached state was discarded before calling `Step`, but this meant that if `Step` failed then MIEngine was left with no cached state, causing a subsequent call to `GetDebugPropertyFromExpression` to fail with a fatal error.
WardenGnaw
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
LGTM. Thank you for your contribution @gareth-rees!
This will be targeted for the next VS Code C/C++ Extension Release.
|
Thank you for the quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
AD7DebugSession.StepInternal, discard cached state after program starts stepping, rather than before.Previously the cached state was discarded before calling
Step, but this meant that ifStepfailed then MIEngine was left with no cached state, causing a subsequent call toGetDebugPropertyFromExpressionto fail with a fatal error.Fixes #1336 (Evaluating a variable after a failed Step Out causes a fatal error, leaving debug session unusable).
Note
BeforeContinueis also called byHandleContinueRequestAsync,HandleIDebugEntryPointEvent2andHandleIDebugEntryPointEvent2, so similar changes might make sense in some or all of those functions, but I didn't make those changes here because the Continue request doesn't have the same possibility of harmless failure as the Step Out request.