Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] fix mypy error in setup.py #4671

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

rakki-18
Copy link
Contributor

Contributes to #3867

The error that gets fixed through this PR:

python-package/setup.py:64: error: Incompatible types in assignment (expression has type "str", variable has type "Path")

Changes introduced

  • Replace the "Path" variable submodule, with a new variable submodule_stem to prevent incompatible assignment error.

@jameslamb jameslamb changed the title fix mypy error in setup.py [python] fix mypy error in setup.py Oct 12, 2021
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@jameslamb jameslamb merged commit b1b6db4 into microsoft:master Oct 13, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants