[ci] reduce duplication in Python Windows CI #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
reviewed
Mar 31, 2020
Co-Authored-By: Nikita Titov <[email protected]>
StrikerRUS
reviewed
Apr 1, 2020
Co-Authored-By: Nikita Titov <[email protected]>
StrikerRUS
approved these changes
Apr 1, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion from #2936 (comment). Right now some CI logic is duplicated in
.vsts-ci.ymland.appveyor.yml. Similar to how we've centralized that logic for mac and linux builds in.ci/scripts, in this PR I propose cutting out that duplication and centralizing the logic in.ci/tetst_windows.ps1.This should make it a little easier to make changes (such as changing our pegged version of scikit-learn whenever #2949 is merged) and should make #2936 easier to review.