[R-package] [ci] added check on number of R CMD CHECK notes #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
approved these changes
Mar 25, 2020
oh sure! I did that on my fork already actually Travis: https://travis-ci.org/github/jameslamb/LightGBM/jobs/666851877 You can see this error in the logs:
|
|
@jameslamb |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in CI, we run
R CMD checkon the R package and fail builds if ERRORs or WARNINGs are encountered. As we get closer to CRAN (#629), I'd like to start limiting the NOTEs being generated. Currently Linux and macOS builds have 3 NOTEs. One is being addressed in #2911 , the other two are not problematic.Following @StrikerRUS 's suggestion in #2911 (comment), this PR proposing putting an upper limit on the number of NOTEs.
This PR has it set to 3, and mainly introduces how we'll enforce this. I think we should merge this, then change it from 3 to 2 on #2911 . I think it's better for this to be a separate PR so that other changes in the repo don't introduce new notes (like I accidentally did in #2803 and then had to fix in #2928 ).