Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug flags #2825

Merged
merged 11 commits into from
Mar 1, 2020
Merged

Debug flags #2825

merged 11 commits into from
Mar 1, 2020

Conversation

guolinke
Copy link
Collaborator

@guolinke guolinke commented Feb 26, 2020

for #2820 and #1588

  • add documents

CMakeLists.txt Outdated Show resolved Hide resolved
windows/LightGBM.vcxproj Outdated Show resolved Hide resolved
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! But I don't understand LightGBM.vcxproj so won't let my approval count towards a merge.

@guolinke I think we should document this somewhere for developers too. Otherwise it will be an undocumented "hidden treasure" 😂

windows/LightGBM.sln Outdated Show resolved Hide resolved
windows/LightGBM.sln Outdated Show resolved Hide resolved
@guolinke
Copy link
Collaborator Author

thanks @jameslamb , will add related documentation when have time.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolinke I can help with docs if you wish.

@guolinke
Copy link
Collaborator Author

@StrikerRUS Thank you so much! And it would be better!

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Feb 28, 2020

@guolinke WDYT about compiling LightGBM in debug mode to check that everithing is OK at CI?
For example, we can set debug here, because we cannot set it for regular job as we use artifacts from there in releases.

cmake -DUSE_MPI=ON ..

@guolinke
Copy link
Collaborator Author

Good idea!

@StrikerRUS
Copy link
Collaborator

I added docs for new compilation options and set MPI job to be run in Debug mode in the latest commits.

@guolinke guolinke merged commit 8d90bbe into master Mar 1, 2020
@StrikerRUS StrikerRUS deleted the debug-flag branch March 1, 2020 11:52
@StrikerRUS StrikerRUS mentioned this pull request Mar 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants