Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] add cv() function #3847

Closed
jameslamb opened this issue Jan 25, 2021 · 1 comment
Closed

[dask] add cv() function #3847

jameslamb opened this issue Jan 25, 2021 · 1 comment

Comments

@jameslamb
Copy link
Collaborator

Summary

As of this writing, lightgbm.dask only supports model classes that mimic the scikit-learn API. It should also support a function, equivalent to lightgbm.engine.cv.

def cv(params, train_set, num_boost_round=100,

Because cv() expects to be given a LightGBM Dataset object, this also implies creating a new class lightgbm.dask.DaskDataset. cv() should take in train_set as a lightgbm.dask.DaskDataset, and should return a regular LightGBM Booster.

Motivation

Having a functional interface would make the transition from non-Dask to Dask easier for users who are already using lightgbm.engine.cv).

References

See the DaskDMatrix in xgboost.dask for some inspiration on how DaskDataset might be implemented.

https://github.com/dmlc/xgboost/blob/a275f4026728ed14fbc70da142ef7a4a1d3de04d/python-package/xgboost/dask.py#L181-L186

DaskDataset may be implemented outside of this feature, to support #3846

@jameslamb
Copy link
Collaborator Author

Closing this in favor of putting it in #2302 with other feature requests. Comment below if you'd like to work on this, and it can be re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant