-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version of pkgdown #3036
Comments
Closed in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature. |
re-opening this since I think it will be fixed by open PR #3072 Leaving some notes for myself. You can see the details of the relevant
So to check that a fix to this worked, after removing
|
…icrosoft#3036) (microsoft#3072) * [R-package] [docs] remove devtools dependency for docs builds * linting * updating docs conda env * empty roxygenize() * env for R libraries * get logs * remove comment * added pkgdown URLs * more paths * fix incorrect YAML keys * update DESCRIPTION URL link * more URL changes * revert DESCRIPTION changes * remove ca-certificates * empty commit * Update docs/conf.py Co-authored-by: Nikita Titov <[email protected]> * empty commit * remove outdated line in build_r.R Co-authored-by: Nikita Titov <[email protected]>
Sorry, missclick. |
…icrosoft#3036) (microsoft#3072) * [R-package] [docs] remove devtools dependency for docs builds * linting * updating docs conda env * empty roxygenize() * env for R libraries * get logs * remove comment * added pkgdown URLs * more paths * fix incorrect YAML keys * update DESCRIPTION URL link * more URL changes * revert DESCRIPTION changes * remove ca-certificates * empty commit * Update docs/conf.py Co-authored-by: Nikita Titov <[email protected]> * empty commit * remove outdated line in build_r.R Co-authored-by: Nikita Titov <[email protected]>
…icrosoft#3036) (microsoft#3072) * [R-package] [docs] remove devtools dependency for docs builds * linting * updating docs conda env * empty roxygenize() * env for R libraries * get logs * remove comment * added pkgdown URLs * more paths * fix incorrect YAML keys * update DESCRIPTION URL link * more URL changes * revert DESCRIPTION changes * remove ca-certificates * empty commit * Update docs/conf.py Co-authored-by: Nikita Titov <[email protected]> * empty commit * remove outdated line in build_r.R Co-authored-by: Nikita Titov <[email protected]>
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Summary
Build R documents with new version of
pkgdown
.Motivation
1.5
version introducesrepo$url
config option. This option will allow to drop our ugly postprocessing JS workaround for incorrect source files links as our R package is located in a subdirectory:https://github.com/microsoft/LightGBM/blob/master/R-package/pkgdown/extra.js
References
LightGBM/docs/conf.py
Line 238 in 2c18a0f
https://github.com/r-lib/pkgdown/releases/tag/v1.5.0
The text was updated successfully, but these errors were encountered: