fixed list of SOURCES

microsoft · Mar 25, 2020 · daa9da5 · daa9da5
1 parent 6edf614
commit daa9da5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.ci/test_r_package.sh b/.ci/test_r_package.sh
@@ -91,7 +91,7 @@ if grep -q -R "WARNING" "$LOG_FILE_NAME"; then
     exit -1
 fi
 
-ALLOWED_CHECK_NOTES=3
+ALLOWED_CHECK_NOTES=2
 NUM_CHECK_NOTES=$(
     cat ${LOG_FILE_NAME} \
         | grep -e '^Status: .* NOTE.*' \

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -235,12 +235,12 @@ file(GLOB SOURCES
 )
 
 add_executable(lightgbm src/main.cpp ${SOURCES})
-set(SOURCES "${SOURCES} src/c_api.cpp")
+list(APPEND SOURCES "src/c_api.cpp")
 
 # Only build the R part of the library if building for
 # use with the R package
 if(BUILD_FOR_R)
-  set(SOURCES "${SOURCES} src/lightgbm_R.cpp")
+  list(APPEND SOURCES "src/lightgbm_R.cpp")
 endif(BUILD_FOR_R)
 
 add_library(_lightgbm SHARED ${SOURCES})