Skip to content

Commit

Permalink
minor cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jameslamb committed Jun 9, 2020
1 parent 6b4a1f1 commit c65a910
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 10 deletions.
13 changes: 7 additions & 6 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ branches:

environment:
matrix:
- TASK: r-package
R_VERSION: 4.0
COMPILER: MINGW
TOOLCHAIN: MSYS
- TASK: r-package
- COMPILER: MINGW
TASK: r-package
R_VERSION: 3.6
TOOLCHAIN: MINGW
- COMPILER: MSVC
TASK: r-package
R_VERSION: 4.0
COMPILER: MSVC
TOOLCHAIN: MSVC
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
- COMPILER: MSVC
TASK: python
Expand Down
6 changes: 5 additions & 1 deletion .ci/test_r_package_windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ if ($env:R_MAJOR_VERSION -eq "3") {
$env:RTOOLS_EXE_FILE = "rtools40-x86_64.exe"
$env:R_WINDOWS_VERSION = "4.0.0"
} else {
Write-Output "Unrecognized R version: $env:R_VERSION"
Write-Output "[ERROR] Unrecognized R version: $env:R_VERSION"
Check-Output $false
}

Expand All @@ -72,6 +72,10 @@ if ($env:TOOLCHAIN -eq "MINGW") {
Write-Output "Telling R to use MSYS"
$install_libs = "$env:BUILD_SOURCESDIRECTORY/R-package/src/install.libs.R"
((Get-Content -Path $install_libs -Raw) -Replace 'use_msys2 <- FALSE','use_msys2 <- TRUE') | Set-Content -Path $install_libs
} elseif ($env:TOOLCHAIN -eq "MSVC") {
# no customization for MSVC
} else {
Write-Output "[ERROR] Unrecognized coompiler: $env:TOOLCHAIN"
}

# download R and RTools
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
test:
name: ${{ matrix.task }} (${{ matrix.os }}, ${{ matrix.compiler }})
name: ${{ matrix.task }} (${{ matrix.os }}, ${{ matrix.compiler }}, R ${{ matrix.r_version }})
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
5 changes: 3 additions & 2 deletions .vsts-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,12 @@ jobs:
TASK: r-package
COMPILER: MSVC
R_VERSION: 3.6
TOOLCHAIN: MSVC
r_package_mingw:
TASK: r-package
COMPILER: MINGW
TOOLCHAIN: MINGW
R_VERSION: 3.6
R_VERSION: 4.0
TOOLCHAIN: MSYS
regular:
TASK: regular
PYTHON_VERSION: 3.6
Expand Down

0 comments on commit c65a910

Please sign in to comment.