Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: symlinking breaks 'git clean' #2026

Closed
markfields opened this issue May 4, 2020 · 3 comments
Closed

Build: symlinking breaks 'git clean' #2026

markfields opened this issue May 4, 2020 · 3 comments
Assignees
Labels
bug Something isn't working external Issues to track work that is outside of our repo

Comments

@markfields
Copy link
Member

Describe the bug

After symlinking, running git clean -fdX hits a bunch of failure like this, from infinitely nested node_modules paths as it navigates through symlinks:

warning: Could not stat path 'examples/components/flow-scroll/node_modules/@microsoft/fluid-component-base/node_modules/@microsoft/fluid-map/node_modules/@microsoft/fluid-runtime-definitions/node_modules/@microsoft/fluid-driver-definitions/tsconfig.esnext.tsbuildinfo': Filename too long
@markfields markfields added the bug Something isn't working label May 4, 2020
@ghost ghost added the triage label May 4, 2020
@markfields
Copy link
Member Author

We should almost definitely just close this, but I wanted to bring it to your attention. Thanks.

@arinwt
Copy link
Contributor

arinwt commented May 5, 2020

I think this is an issue with git for windows. I opened an issue a while back:
git-for-windows/git#2298

@curtisman
Copy link
Member

This is a problem even with lerna's only symlink, We can't use git clean on windows.

@curtisman curtisman added external Issues to track work that is outside of our repo and removed triage labels May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues to track work that is outside of our repo
Projects
None yet
Development

No branches or pull requests

3 participants