Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpStorage export from replay-driver #19523

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

ChumpChief
Copy link
Contributor

The OpStorage class is non-functional and unused, this change would remove it.

AB#7148

@ChumpChief ChumpChief requested a review from jatgarg February 7, 2024 18:04
@github-actions github-actions bot added area: driver Driver related issues public api change Changes to a public API base: main PRs targeted against main branch labels Feb 7, 2024
@ChumpChief ChumpChief requested a review from alexvy86 February 7, 2024 18:04
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Feb 7, 2024

@fluid-example/bundle-size-tests: +187 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 511.82 KB 511.86 KB +44 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 244.63 KB 244.65 KB +22 Bytes
loader.js 170.65 KB 170.67 KB +22 Bytes
map.js 46.41 KB 46.42 KB +11 Bytes
matrix.js 149.11 KB 149.12 KB +11 Bytes
odspDriver.js 96.8 KB 96.83 KB +33 Bytes
odspPrefetchSnapshot.js 42.26 KB 42.29 KB +22 Bytes
sharedString.js 168.49 KB 168.5 KB +11 Bytes
sharedTree.js 333.77 KB 333.77 KB No change
Total Size 1.87 MB 1.87 MB +187 Bytes

Baseline commit: 9188d64

Generated by 🚫 dangerJS against 89b1f3c

@ChumpChief ChumpChief merged commit 6149170 into microsoft:main Feb 15, 2024
30 checks passed
@ChumpChief ChumpChief deleted the RemoveOpStorage branch February 15, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants