From 3290d12a243aa681f290e3977ccc9b196ffe61cf Mon Sep 17 00:00:00 2001 From: Harsha Vardhan Simhadri Date: Sat, 19 Aug 2023 16:44:30 -0700 Subject: [PATCH 1/2] Undo mistake, let frontier read in PQ flash index be asynchronous --- src/pq_flash_index.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pq_flash_index.cpp b/src/pq_flash_index.cpp index b0121493e..cd0e87c33 100644 --- a/src/pq_flash_index.cpp +++ b/src/pq_flash_index.cpp @@ -1392,7 +1392,7 @@ void PQFlashIndex::cached_beam_search(const T *query1, const uint64_t io_timer.reset(); #ifdef USE_BING_INFRA reader->read(frontier_read_reqs, ctx, - false); // synhronous reader for Bing. + true); // synhronous reader for Bing. #else reader->read(frontier_read_reqs, ctx); // synchronous IO linux #endif From f4df4a3ed048036cbce71017b595374d22e7f2d8 Mon Sep 17 00:00:00 2001 From: harsha vardhan simhadri Date: Mon, 21 Aug 2023 10:33:38 -0700 Subject: [PATCH 2/2] address changes requested --- src/pq_flash_index.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pq_flash_index.cpp b/src/pq_flash_index.cpp index cd0e87c33..e76debcdf 100644 --- a/src/pq_flash_index.cpp +++ b/src/pq_flash_index.cpp @@ -1392,7 +1392,7 @@ void PQFlashIndex::cached_beam_search(const T *query1, const uint64_t io_timer.reset(); #ifdef USE_BING_INFRA reader->read(frontier_read_reqs, ctx, - true); // synhronous reader for Bing. + true); // asynhronous reader for Bing. #else reader->read(frontier_read_reqs, ctx); // synchronous IO linux #endif @@ -1561,7 +1561,7 @@ void PQFlashIndex::cached_beam_search(const T *query1, const uint64_t io_timer.reset(); #ifdef USE_BING_INFRA - reader->read(vec_read_reqs, ctx, false); // sync reader windows. + reader->read(vec_read_reqs, ctx, true); // async reader windows. #else reader->read(vec_read_reqs, ctx); // synchronous IO linux #endif