Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding and dtype issues #738

Merged
merged 14 commits into from
Oct 2, 2023
Merged

Fix padding and dtype issues #738

merged 14 commits into from
Oct 2, 2023

Conversation

tjruwase
Copy link
Contributor

Fix padding, dtype, and version issues

Copy link
Contributor

@minjiaz minjiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Added some minor suggestions to keep the main generation function cleaner.

inference/huggingface/zero_inference/run_model.py Outdated Show resolved Hide resolved
inference/huggingface/zero_inference/run_model.py Outdated Show resolved Hide resolved
inference/huggingface/zero_inference/run_model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@minjiaz minjiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tjruwase tjruwase merged commit 58e4e9c into master Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants