[Device]Support DeepSpeedChat to run on different device besides cuda #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ys950902
requested review from
jeffra,
samyam,
tjruwase,
ShadenSmith,
conglongli,
awan-10,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi,
duli2012,
mrwyattii,
yaozhewei,
arashb and
xiaoxiawu-microsoft
as code owners
tjruwase
reviewed
Sep 22, 2023
applications/DeepSpeed-Chat/training/step1_supervised_finetuning/prompt_eval.py
Outdated
Show resolved
Hide resolved
tjruwase
reviewed
Sep 22, 2023
applications/DeepSpeed-Chat/training/step2_reward_model_finetuning/rw_eval.py
Outdated
Show resolved
Hide resolved
|
@ys950902, thanks! Please see the feedback. |
|
Hi @tjruwase, many thanks with your feedback, I have updated the code with your suggestions, could you please take a look on it. |
tjruwase
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to support DeepSpeedChat to run on different other device besides cuda, use get_accelerator from deepspeed to replace the fixed cuda.