Inference UTs check for trition support from accelerator #6782
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raza-sikander
requested review from
tjruwase,
loadams and
tohtana
as code owners
loadams
reviewed
Nov 25, 2024
| @@ -27,8 +27,8 @@ def ref_torch_attention(q, k, v, mask, sm_scale): | |||
| @pytest.mark.parametrize("causal", [True, False]) | |||
| @pytest.mark.parametrize("use_flash", [True, False]) | |||
| def test_attention(BATCH, H, N_CTX, D_HEAD, causal, use_flash, dtype=torch.float16): | |||
| if not deepspeed.HAS_TRITON: | |||
| pytest.skip("triton has to be installed for the test") | |||
| if not deepspeed.get_accelerator().is_triton_supported(): | |||
There was a problem hiding this comment.
Thanks @raza-sikander - do you think we can extrapolate this to replace all instances of HAS_TRITON?
There was a problem hiding this comment.
@loadams Yes.
This replacing would help cover the case where triton is installed on system but its not supported by device, test would still run as the triton has been installed and fail.
So the ideal case would be to check if it is supported.
loadams
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking if installed or not check for support. Skip if not supported.