Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover variables for NCCL backend on AML without mpi4py #542

Merged
merged 11 commits into from
Nov 19, 2020
Merged

Conversation

awan-10
Copy link
Contributor

@awan-10 awan-10 commented Nov 19, 2020

This PR will allow us to discover that we are running on AzureML and discover the required flags to initialize the NCCL backend in PyTorch without relying on mpi4py.

@awan-10 awan-10 marked this pull request as draft November 19, 2020 21:28
@jeffra jeffra marked this pull request as ready for review November 19, 2020 22:30
Copy link
Collaborator

@jeffra jeffra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Ammar! After addressing Shaden's comment I think we're good to merge (after tests pass).

@jeffra jeffra merged commit 1b45917 into master Nov 19, 2020
@awan-10 awan-10 deleted the amawa/aml branch November 19, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants