Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TB bug when no output path set #523

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Fix TB bug when no output path set #523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9afd829
fix bug on non-DLTS infra when no output path set
jeffra Nov 11, 2020
f1aa87b
Merge branch 'master' into jeffra/tb-bug-fix
jeffra Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
from .utils import ensure_directory_exists

MEMORY_OPT_ALLREDUCE_SIZE = 500000000
SUMMARY_WRITER_DIR_NAME = "JobId"

try:
from apex_C import flatten
Expand Down Expand Up @@ -271,9 +270,17 @@ def get_summary_writer(self,
else:
if self.tensorboard_job_name():
name = self.tensorboard_job_name()

# Infrastructure-specific job-id
if 'DLWS_JOB_ID' in os.environ:
SUMMARY_WRITER_DIR_NAME = os.path.join(os.environ['DLWS_JOB_ID'], "logs")
log_dir = os.path.join(base, SUMMARY_WRITER_DIR_NAME, name)
infra_job_id = os.environ['DLWS_JOB_ID']
elif 'DLTS_JOB_ID' in os.environ:
infra_job_id = os.environ['DLTS_JOB_ID']
else:
infra_job_id = 'unknown-job-id'

summary_writer_dir_name = os.path.join(infra_job_id, "logs")
log_dir = os.path.join(base, summary_writer_dir_name, name)

os.makedirs(log_dir, exist_ok=True)

Expand Down