Fix urls in tutorial #436
Merged
Fix urls in tutorial #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conglongli
requested review from
arashashari,
awan-10,
cli99,
eltonzheng,
jeffra,
minjiaz,
niumanar,
RezaYazdaniAminabadi,
samyam and
tjruwase
as code owners
arashashari
approved these changes
Sep 24, 2020
RezaYazdaniAminabadi
approved these changes
Sep 24, 2020
|
After discussing with @ShadenSmith and @tjruwase, we decided that files in docs should have relative path in order to support local edits. As an alternative solution, we added a real readme under azure to just point to our tutorial on website. On the other hand, I fixed some other real path mistakes in tutorial. |
tjruwase
reviewed
Sep 24, 2020
tjruwase
reviewed
Sep 24, 2020
tjruwase
reviewed
Sep 24, 2020
ShadenSmith
approved these changes
Sep 24, 2020
tjruwase
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues such as #428. The cause is that if we don't use the absolute url path, the links only work when accessed via deepspeed.ai. Now I changed the urls (including images) to absolute path for all tutorial pages.