Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LoRA Fuse/Unfuse in Hybrid Engine #3563

Merged
merged 20 commits into from
Jul 5, 2023
Merged

Fix LoRA Fuse/Unfuse in Hybrid Engine #3563

merged 20 commits into from
Jul 5, 2023

Conversation

sxjscience
Copy link
Contributor

@sxjscience sxjscience commented May 18, 2023 •
edited
Loading

@sxjscience
Copy link
Contributor Author

@microsoft-github-policy-service agree

@sxjscience
Copy link
Contributor Author

@awan-10 @jeffra the unit-test has passed. Would you be able to review the PR?

cmikeh2
cmikeh2 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@cmikeh2 cmikeh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you!

@awan-10 awan-10 enabled auto-merge (squash) June 30, 2023 20:54
@awan-10
Copy link
Contributor

awan-10 commented Jun 30, 2023

@sxjscience - Thank you so much for this detailed PR and investigation! Sorry for the delay in reviewing!

@awan-10
Copy link
Contributor

awan-10 commented Jun 30, 2023

@sxjscience - I have put this PR to auto-merge when the tests pass but I see that the latest round of tests has one failing nv-inference test. Can you please take a look and resolve the issue?

@sxjscience
Copy link
Contributor Author

Will take a look later today.

auto-merge was automatically disabled July 2, 2023 04:29

Head branch was pushed to by a user without write access

@sxjscience
Copy link
Contributor Author

@awan-10 Would you have time to take a look at the latest change? CI has been fixed.

@tjruwase tjruwase merged commit d81dfda into deepspeedai:master Jul 5, 2023
This was referenced Jul 5, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmikeh2 cmikeh2 cmikeh2 approved these changes

@tjruwase tjruwase tjruwase approved these changes

@jeffra jeffra Awaiting requested review from jeffra

@RezaYazdaniAminabadi RezaYazdaniAminabadi Awaiting requested review from RezaYazdaniAminabadi

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

@awan-10 awan-10 Awaiting requested review from awan-10

@arashb arashb Awaiting requested review from arashb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@sxjscience @awan-10 @cmikeh2 @tjruwase @jeffra