Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-bit adam #353

Merged
merged 22 commits into from
Sep 8, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update utils.py
jeffra authored Sep 8, 2020
commit cd2fd9e9c175cff7cdf14570114f112c911d0a30
3 changes: 2 additions & 1 deletion deepspeed/runtime/utils.py
Original file line number Diff line number Diff line change
@@ -24,7 +24,8 @@ def __init__(self, param_groups=None, mpu=None, zero_reduce_scatter=False):
for param in group:
self.params.append(param)

def check_using_norm(self, norm_group, reduce_overflow=False):
def check_using_norm(self, norm_group, reduce_overflow=True):
#TODO: I don't think reduce_overflow is needed if mpu is None
overflow = -1 in norm_group

if self.mpu is not None: