Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deadlock for unsynchronized non-zero checkpointing #297

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Avoid deadlock for unsynchronized non-zero checkpointing #297

merged 3 commits into from
Jul 22, 2020
+50 −31

Conversation

tjruwase
Copy link
Contributor

For non-ZeRO checkpointing, we should not synchronize all ranks at checkpoint. This way we avoid deadlocks.

@tjruwase tjruwase merged commit 3cc96e1 into master Jul 22, 2020
@bobisapotato bobisapotato mentioned this pull request Jan 24, 2021
Merged
@jeffra jeffra deleted the olruwase/unsync_checkpoint branch September 24, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffra jeffra

@ShadenSmith ShadenSmith

@samyam samyam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tjruwase @jeffra