Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DeepSpeed init to accept dictionary instead of args #81

Closed
jeffra opened this issue Feb 14, 2020 · 2 comments · Fixed by #632
Closed

Allow DeepSpeed init to accept dictionary instead of args #81

jeffra opened this issue Feb 14, 2020 · 2 comments · Fixed by #632
Labels
enhancement New feature or request

Comments

@jeffra
Copy link
Collaborator

jeffra commented Feb 14, 2020

We should remove the need for args to be passed to deepspeed init, ideally we should accept a dictionary which represents everything so we can write smaller tests.

@jeffra jeffra added the enhancement New feature or request label Feb 14, 2020
@jackshi0912
Copy link

+1
It would be better if init could ask the data it needs instead of handling file I/O and looking for params in args. Some systems may use very special methods to load yaml, json, protobuf, etc. into memory for initialization and configuration.

@jeffra
Copy link
Collaborator Author

jeffra commented Feb 20, 2020

In the process of implementing this enhancement we will consider removing the --deepspeed flag since this is not used internally in DeepSpeed code. It should be up to the user if they want to implement a DeepSpeed and non-DeepSpeed version of their code controlled by a flag.

jeffra added a commit that referenced this issue Sep 2, 2020
* Sparse attention

Co-authored-by: Arash Ashari <[email protected]>
@jeffra jeffra linked a pull request Jan 6, 2021 that will close this issue
rraminen pushed a commit to rraminen/DeepSpeed that referenced this issue Apr 28, 2021
* fix transformer kernel call parameters

* remove post-ln modeling
delock added a commit to delock/DeepSpeedSYCLSupport that referenced this issue Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants