Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1903][MAS4.2.5] [Labels and Relationships - Settings] Voiceover announce the same label for “Path to ngrok", "Locale", "Localhost Override"and "User ID" present in the "settings" pane #1970

Merged
merged 3 commits into from
Nov 7, 2019
Merged

[ISSUE#1903][MAS4.2.5] [Labels and Relationships - Settings] Voiceover announce the same label for “Path to ngrok", "Locale", "Localhost Override"and "User ID" present in the "settings" pane #1970

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66a540b
Add condition to aria-labelledby in TextField
ceciliaavila Nov 5, 2019
3be36bf
Merge branch 'master' into fix/incorrect-settings-labels-announcement
denscollo Nov 5, 2019
cdaf343
Update arialabelby default value
denscollo Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sdk/ui-react/src/widget/textField/textField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class TextField extends Component<TextFieldProps, {}> {
<div className={`${styles.inputContainer} ${inputContainerClassName}`}>
{this.labelNode}
<input
aria-labelledby="errormessagesub"
aria-labelledby={errorMessage ? 'errormessagesub' : undefined}
className={inputClassName}
id={this.inputId}
ref={this.setInputRef}
Expand Down