Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently selected Theme does not appear in Menu like it should #1239

Closed
cwhitten opened this issue Jan 17, 2019 · 0 comments · Fixed by #1280
Closed

Currently selected Theme does not appear in Menu like it should #1239

cwhitten opened this issue Jan 17, 2019 · 0 comments · Fixed by #1280
Assignees
@a-b-r-o-w-n
Labels
Bug Your classic code defect P1 Painful if we don't fix, won't block releasing

Comments

@cwhitten
Copy link
Member

Version

4.2.1

Describe the bug

Selecting different Themes via the File menu are not mutually exclusive

To Reproduce

Steps to reproduce the behavior:

  1. Click File -> Themes -> Dark
  2. Click File -> Themes -> Light
  3. Click File -> Themes
  4. See in the menu that both Light and Dark are checked, but Light is applied.

Expected behavior

Only one Theme should be indicated

Screenshots

screen shot 2019-01-17 at 10 12 42 am
@cwhitten cwhitten added Bug Your classic code defect P1 Painful if we don't fix, won't block releasing 4.3 labels Jan 17, 2019
@cwhitten cwhitten changed the title Currently selected Theme does not appear like it should Currently selected Theme does not appear in Menu like it should Jan 17, 2019
@tonyanziano tonyanziano self-assigned this Jan 31, 2019
@a-b-r-o-w-n a-b-r-o-w-n mentioned this issue Feb 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
Bug Your classic code defect P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix theme menu state on mac a-b-r-o-w-n/BotFramework-Emulator
3 participants
@cwhitten @tonyanziano @a-b-r-o-w-n