Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot Framework Composer integration with Power Virtual Agents v1 is broken on .test and .preprod environments #9779

Open
2 of 8 tasks
EricDahlvang opened this issue Nov 14, 2024 · 0 comments
Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working

Comments

@EricDahlvang
Copy link
Member

EricDahlvang commented Nov 14, 2024

Describe the bug

Bot Framework Composer integration with Power Virtual Agents v1 is broken on .test and .preprod environments. Cannot download the .zip. Looks related to island urls or something. I'm still investigating, but getAuthCredentials: BotFramework-Composer/Composer/packages/server/src/externalContentProvider/powerVirtualAgentsProvider.ts at bc5cc73817881d4835f7c8ef68a6d6be905f88ee · microsoft/BotFramework-Composer appears to be wrong. We are always using prod credentials, even when opening a test or ppe bot.

if (url.hostname.includes('.int.') || url.hostname.includes('.ppe.')) {
log('Using INT / PPE auth credentials.');
return {
clientId: COMPOSER_1P_APP_ID,
scopes: [${PVA_TEST_APP_ID}/.default],
targetResource: PVA_TEST_APP_ID,
};

Likely the hostname check needs to include .test. but currently only checks for .int. and .ppe.

Image

Version

latest

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Additional context

@EricDahlvang EricDahlvang added Needs-triage A new issue that require triage Type: Bug Something isn't working labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant