Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# Teams-auth / about AAD SSO #3849

Closed
PyeongsaengCoding opened this issue Nov 22, 2022 · 8 comments
Closed

C# Teams-auth / about AAD SSO #3849

PyeongsaengCoding opened this issue Nov 22, 2022 · 8 comments
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository.

Comments

@PyeongsaengCoding
Copy link

Sample information

  1. 46.Teams-auth

Describe the bug

  1. If clicked accept in the Teams desktop app, the accept page does not open
  2. If the accept page open in Teams web, it automatically accepted it without any procedure

To Reproduce

Steps to reproduce the behavior:

Describe the bug about 1.

  1. Go to 'Teames desktop'
  2. Click on 'Teams-auth app'

Describe the bug about 2.

  1. Go to 'Teames web'
  2. Click on 'Teams-auth app'
  3. (but at the very first time i try to get a authorization i needed to click the authorization button)
@PyeongsaengCoding PyeongsaengCoding added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Nov 22, 2022
@anishprasad01
Copy link
Contributor

Hi @dhddldid,

Could you please provide:

  • More information regarding each scenario.
  • More details regarding your deployment and testing environment.

@anishprasad01 anishprasad01 added customer-reported Issue is created by anyone that is not a collaborator in the repository. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Nov 22, 2022
@PyeongsaengCoding
Copy link
Author

PyeongsaengCoding commented Nov 23, 2022

Thank you for reply

The detailed scenario is as follows

  1. I followed the 46.teams-auth code

  2. I followed the document to register azure bot and to configure sso.

  3. And in the web version of Teams, it worked as follows.
    teams-web_01
    teams-web_02
    The problem described in "Describe the bug about2" occurs here.
    At first, there was a button to agree, but now it automatically agrees.

  4. In addition, the following phenomenon occurs in Teasm's desktop app
    (To return to the scenario for consent, we modified the permission of Microsoft Graph.)
    teams-desktop_01
    Press the displayed "Continue" button
    The following window did not appear
    This is about "Describe the bug about 1."
    teams-desktop_02


  1. The detailed environment is as follows:

    1. Resources
      reosurces

    2. About Azure bot
      bot_Config

    3. About App registrations
      App_regi_Authentication

    App_regi_Expose an API

@anishprasad01
Copy link
Contributor

Thank you. I will attempt to reproduce this issue.

@anishprasad01
Copy link
Contributor

anishprasad01 commented Nov 28, 2022

@dhddldid

At the moment, I am unable to reproduce Bug 1. With the User.Read scope, I am able to see the consent window when the bot is running in Teams.

As for Bug 2, I believe that this may actually be intended behavior, and not a bug. After you log in once, you remain logged in until the token expires unless you explicitly log out.

@PyeongsaengCoding
Copy link
Author

@anishprasad01 Thank you for thinking about the bug and answering.

I will share my opinion on the answer.

In Bug 1, can you try to press permission after turning on the Teams desktop app without opening the web page?
If you follow the above scenario and the page opens the same way, I'll closed bug1.

In Bug 2, if you want to reopen pages that allow permissions, you can:

When you modify the permissions in AAD as shown in the figure, you will have to accept the permissions again in Teams, as you saw in the phrase "You are editing permission(s) to your application, users will have to have them already done if they appear on the Accept Permissions page as if they were logged in for the first time. At this time, please check if the authority is accepted automatically.
bug2

I don't think it has anything to do with login and token.

Could you give it another try?

@anishprasad01
Copy link
Contributor

can you try to press permission after turning on the Teams desktop app without opening the web page?

Do you mean without using the Teams Web App? I have attempted only in the desktop app, as per your report.

permissions in AAD as shown in the figure, you will have to accept the permissions again in Teams

Correct, but your sign-in will be retained, so you will not be asked to log in again once you accept the permissions.

@PyeongsaengCoding
Copy link
Author

@anishprasad01

  1. You're right, I'm referring to running only on the desktop app.

  2. Thanks for trying.

Thanks for checking the issues. We will see you often in the future as we develop the Teams app.

Am I asking for closed? This is my first time doing a git issue.

@anishprasad01
Copy link
Contributor

Thanks for clarifying. Feel free to open an issue in the appropriate repository as needed, and good luck with your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository.
Projects
None yet
Development

No branches or pull requests

2 participants