Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links by redirecting to QnA prompting sample #2851

Closed
RedAvenge opened this issue Oct 19, 2020 · 3 comments
Closed

Broken links by redirecting to QnA prompting sample #2851

RedAvenge opened this issue Oct 19, 2020 · 3 comments
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@RedAvenge
Copy link

Describe the bug

Hey there,
the links in the readme of main/experimental/qnamaker-prompting are broken. They link to a replaced sample but in the normal samples folder to which they are linking is no 70.qnamaker-multiturn-sample.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://github.com/microsoft/BotBuilder-Samples/tree/main/experimental/qnamaker-prompting'
  2. Click on one of the links (both are broken)
  3. See error, that the page was not found.

Expected behavior

Links should work and redirect to the proper sample and the sample itself should be available too.

@RedAvenge RedAvenge added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Oct 19, 2020
@RedAvenge
Copy link
Author

I just saw that a similar issue #2727 is still open. But I think my issue has something more to it, because the other issue does not mentioned that the sample itself is not available at all in the samples folder.

In any case, sorry for the dupe but I did not searched for an existing issues in the first place because I think this is such a "simple" error which should be fixable without the issue moving to the third page :)

@dmvtech dmvtech added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Oct 19, 2020
@cleemullins
Copy link
Contributor

@v-kydela Kyle, could you submit the PR to cleanup these links? Thanks!

@v-kydela
Copy link
Contributor

Closing to address here: #2727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

No branches or pull requests

4 participants