Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.multilingual-bot - Lacks the actual functionality #2001

Closed
samanulla opened this issue Nov 20, 2019 · 4 comments
Closed

17.multilingual-bot - Lacks the actual functionality #2001

samanulla opened this issue Nov 20, 2019 · 4 comments
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.

Comments

@samanulla
Copy link

Github issues for JS

Sample information

  1. Sample type: samples
  2. Sample language: nodejs
  3. Sample name: 17.multilingual-bot

Describe the bug

Main issue is - This bot does not seem to do what it says. I was looking for this sample to demo to a customer for showing real time translation using choice of languages provided. Though the code got me started, but ran into issues and finally had to build my own echo bot to demo the customer.

Issue #1: The instruction for code snippet is wrong.
adapter.use(new TranslatorMiddleware(languagePreferenceProperty, process.env.translatorKey));
The parameters are in incorrect order. The right code is:
adapter.use(new TranslatorMiddleware(process.env.translatorKey, languagePreferenceProperty));

Issue #2: The call to the translation service should happen in multilingualBot.js but it is not there. Also beyond the list of language selection and once you select the language it gets set in the context. But beyond this it wont call Translater text service or it does not have the logic to go beyond the above said functionality.

@Stevenic Stevenic added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Nov 22, 2019
@cleemullins
Copy link
Contributor

I've asked Southworks to look into this, and make changes as needed.

@cleemullins
Copy link
Contributor

This is being worked on today by the good folks from Southworks.

@gabog gabog added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Dec 2, 2019
@gabog
Copy link
Contributor

gabog commented Dec 2, 2019

PR is pending that fixes this issue.

@a-b-r-o-w-n
Copy link
Contributor

@samanulla This has been fixed and merged into master. Closing this issue. Feel free to re-open if you still have issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.
Projects
None yet
Development

No branches or pull requests

5 participants