Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fluff from AdaptiveCardPrompt Sample after SDK merge #1987

Closed
6 tasks
mdrichardson opened this issue Nov 16, 2019 · 1 comment
Closed
6 tasks

Remove fluff from AdaptiveCardPrompt Sample after SDK merge #1987

mdrichardson opened this issue Nov 16, 2019 · 1 comment
Assignees

Comments

@mdrichardson
Copy link
Contributor

PR for AdaptiveCardPrompt Samples

C# AdaptiveCardPrompt relies on a couple of pieces of the Dialogs package that are internal. It's modified a little in the sample so that the sample can stand on its own.

Node AdaptiveCardPrompt is a compiled version of adaptiveCardPrompt.ts and then edited a little for readability.

There are a few comments and some files that will need to be deleted after/if AdaptiveCardPrompt is merged into the SDK -- targeting R8.

Really, it should get a full review, but off-hand it will mostly be:

  • READMEs with updated link for both samples
  • Delete in AdaptiveCardPrompt in both samples (they'll be in the SDK)
  • Ensure all files reference the SDK and not something local, as applicable in both samples
  • Delete RemoveOncePromptInSDK/ from C# sample
  • Adjust namespaces in C# samples
  • Review package.json in node sample
@mdrichardson mdrichardson self-assigned this Nov 18, 2019
@mdrichardson
Copy link
Contributor Author

Closing since this is in the Community Repo now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant